samba.git/lib/ldb/modules, branch master Unnamed repository; edit this file 'description' to name the repository. ldb:sort: generalise both-NULL check to equality check 2024-04-23T01:33:29+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-04-07T02:58:48+00:00 531f31df99341b2cb1afc42538022451ca771983 BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
ldb:sort: check that elements have values 2024-04-23T01:33:29+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-04-07T02:55:27+00:00 d4e69734c65ade0bbb398447012513a7f27e98bd We assume no values is unlikely, since we have been dereferencing ->values[0] forever, with no known reports of trouble. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
We assume no values is unlikely, since we have been dereferencing
->values[0] forever, with no known reports of trouble.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
ldb:mod:sort: rearrange NULL checks 2024-04-23T01:33:29+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-04-07T02:54:34+00:00 d785c1991c922150bab38c36cef3a799448ac304 There are further changes coming here. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
There are further changes coming here.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib: Use talloc_asprintf_addbuf() in rdn_name_add() 2022-12-14T04:32:34+00:00 Volker Lendecke vl@samba.org 2022-11-28T10:25:32+00:00 cbcf7f0d21b146b52bf472a3627b7ea8cd3d0b80 Add implicit NULL checks Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Add implicit NULL checks

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
lib: Fix whitespace 2022-12-14T04:32:34+00:00 Volker Lendecke vl@samba.org 2022-11-28T07:35:57+00:00 7870e82cb4405a983f106a119203f1e193cb2f12 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
CVE-2022-32746 ldb: Make use of functions for appending to an ldb_message 2022-07-27T10:52:36+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2022-02-21T03:27:37+00:00 0a3aa5f908e351201dc9c4d4807b09ed9eedff77 This aims to minimise usage of the error-prone pattern of searching for a just-added message element in order to make modifications to it (and potentially finding the wrong element). BUG: https://bugzilla.samba.org/show_bug.cgi?id=15009 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> 
This aims to minimise usage of the error-prone pattern of searching for
a just-added message element in order to make modifications to it (and
potentially finding the wrong element).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15009

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
CVE-2022-32746 ldb:rdn_name: Use LDB_FLAG_MOD_TYPE() for flags equality check 2022-07-27T10:52:36+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2022-02-15T23:43:52+00:00 41b1fe6d4ae1f547b2f1a0ef8d1aee284b4ef93b Now unrelated flags will no longer affect the result. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15009 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> 
Now unrelated flags will no longer affect the result.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15009

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
ldb/mod/paged_searches: cope with NULL control data 2020-06-13T05:25:31+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2020-04-22T22:31:39+00:00 3fb21ed12e21382607ed9dc8dc879d62ec43f119 We won't get NULL data over ldap, but it can be set via 'local_oid:'. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
We won't get NULL data over ldap, but it can be set via 'local_oid:'.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
CVE-2020-10700: ldb: Always use ldb_next_request() in ASQ module 2020-05-04T08:19:41+00:00 Andrew Bartlett abartlet@samba.org 2020-03-11T03:41:34+00:00 c309e6b2a704472ab2870e226bdaa172b4bf0fb8 We want to keep going down the module stack, and not start from the top again. ASQ is above the ACL modules, but below paged_results and we do not wish to re-trigger that work. Thanks to Andrei Popa <andrei.popa@next-gen.ro> for finding, reporting and working with us to diagnose this issue! BUG: https://bugzilla.samba.org/show_bug.cgi?id=14331 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> 
We want to keep going down the module stack, and not start from the top again.

ASQ is above the ACL modules, but below paged_results and we do not wish to
re-trigger that work.

Thanks to Andrei Popa <andrei.popa@next-gen.ro> for finding,
reporting and working with us to diagnose this issue!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14331

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
ldb modules: paged_search checks control is not NULL (CID 241355) 2019-05-09T22:39:27+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2019-05-08T01:11:43+00:00 47f2264c5e40ca283708310b1b28f03fad6a21a7 It is unlikely to be NULL, since we're in the callback. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> 
It is unlikely to be NULL, since we're in the callback.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>