samba.git/lib/ldb, branch talloc-2.3.2

ldb_parse_test: studio compiler doesn't like empty struct definitions

2020-11-10T06:53:43+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

ldb_key_value_test: studio compiler doesn't like empty struct definitions

2020-11-10T06:53:43+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

ldb_kv_index: fix empty initializer compile warning

2020-11-10T06:53:43+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

lib/util: remove extra safe_string.h file

2020-08-28T02:18:40+00:00

lib/util/safe_string.h is similar to source3/include/safe_string.h, but
the former has fewer checks. It is missing bcopy, strcasecmp, and
strncasecmp.

Add the missing elements to lib/util/safe_string.h remove the other
safe_string.h which is in the source3-specific path. To accomodate
existing uses of str(n?)casecmp, add #undef lines to source files where
they are used.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Aug 28 02:18:40 UTC 2020 on sn-devel-184

Fix FTBFS / Increase the over-estimation for sparse files

2020-08-25T04:23:19+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14418
Signed-off-by: Mathieu Parent 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Aug 25 04:23:19 UTC 2020 on sn-devel-184

ldb_controls: control_to_string avoids crash

2020-07-29T04:43:23+00:00

Otherwise a malformed control with unexpected NULL data will segfault
ldb_control_to_string(), though this is not very likely to affect
anyone in practice as converting controls to strings is rarely
necessary. If it happens at all in Samba it is in Python code.

Found by Honggfuzz using fuzz_ldb_parse_control.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Wed Jul 29 04:43:23 UTC 2020 on sn-devel-184

ldb_ldap: Fix a memleak

2020-07-02T10:38:34+00:00

Don't allocate a temporary value on a long-term context

Signed-off-by: Volker Lendecke 
Reviewed-by: David Mulder

CVE-2020-10730: lib ldb: Check if ldb_lock_backend_callback called twice

2020-07-02T09:01:41+00:00

Prevent use after free issues if ldb_lock_backend_callback is called
twice, usually due to ldb_module_done being called twice. This can happen if a
module ignores the return value from function a function that calls
ldb_module_done as part of it's error handling.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

ldb_ldap: fix off-by-one increment in lldb_add_msg_attr

2020-06-19T08:35:33+00:00

Fix regression introduced by commit ce2bf5c72b6423fff680b3d6a9042103a6cdda55

lldb_add_msg_attr() calls ldb_msg_add_empty() which, in turn, calls
calls _ldb_msg_add_el() which already increments msg->num_elements by one.

As a result, msg->num_elements is bigger than the actual number of
elements and any iteration over elements would step over elements array
boundary.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14413
Signed-off-by: Alexander Bokovoy 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri Jun 19 08:35:33 UTC 2020 on sn-devel-184

lib/ldb: add unit test for ldb_ldap internal code

2020-06-19T07:16:37+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14413
Signed-off-by: Alexander Bokovoy 
Reviewed-by: Andreas Schneider