samba.git/lib/ldb, branch talloc-2.3.3

lib:ldb-samba: Improve calculate_popt_array_length()

2021-06-16T00:34:38+00:00

Note that memcmp() doesn't work well with padding bytes. So avoid it!

(gdb) ptype/o struct poptOption
/* offset    |  size */  type = struct poptOption {
/*    0      |     8 */    const char *longName;
/*    8      |     1 */    char shortName;
/* XXX  3-byte hole  */
/*   12      |     4 */    unsigned int argInfo;
/*   16      |     8 */    void *arg;
/*   24      |     4 */    int val;
/* XXX  4-byte hole  */
/*   32      |     8 */    const char *descrip;
/*   40      |     8 */    const char *argDescrip;

                           /* total size (bytes):   48 */

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

lib:ldb: Use C99 initializers for builtin_popt_options[]

2021-06-16T00:34:38+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

pyldb: Fix Message.items() for a message containing elements

2021-06-11T07:41:38+00:00

Previously, message elements were being freed before the call to
Py_BuildValue(), resulting in an exception being raised. Additionally,
only the first element of the returned list was ever assigned to.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

pyldb: Add test for Message.items()

2021-06-11T07:41:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

tests: Use ldbsearch '--scope instead of '-s'

2021-04-28T03:43:34+00:00

We should use long options in tests to make clear what we are trying to
do.

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

pyldb: fix a typo

2021-04-26T12:32:35+00:00

Signed-off-by: Björn Baumbach 
Reviewed-by: Rowland penny

lib:ldb: Change page size of guidindexpackv1.ldb

2021-04-23T08:26:00+00:00

As this is a TDB file, the file has been backed up using tdbbackup to
get a different page size. This fixes running the repack.py test on
aarch64.

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri Apr 23 08:26:00 UTC 2021 on sn-devel-184

lib:ldb: Use a 1MiB lmdb so the test also passes on aarch64 CentOS stream

2021-04-23T07:35:32+00:00

Signed-off-by: Gary Lockyer 
Reviewed-by: Andreas Schneider

ldb/attrib_handler casefold: simplify space dropping

2021-04-07T03:16:39+00:00

As seen in CVE-2021-20277, ldb_handler_fold() has been making mistakes
when collapsing spaces down to a single space.

This patch fixes the way it handles internal spaces (CVE-2021-20277
was about leading spaces), and involves a rewrite of the parsing loop.

The bug has a detailed description of the problem.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14656

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Apr  7 03:16:39 UTC 2021 on sn-devel-184

ldb: fix ldb_comparison_fold off-by-one overrun

2021-04-07T02:17:34+00:00

We run one character over in comparing all the bytes in two ldb_vals.

In almost all circumstances both ldb_vals would have an allocated '\0'
in the overrun position, but it is best not to rely on that.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett