samba.git/lib/mscat, branch master

lib:mscat: Remove unnecessary casts

2023-09-14T21:35:28+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:mscat: Add missing newlines to logging messages

2023-08-08T04:39:37+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

Remove rudundent check for gnutls_pkcs7_get_embedded_data_oid as we now require GnuTLS 3.6.13

2023-06-30T14:00:38+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

lib;smbd: Fix the -Os build by initializing variables

2021-08-06T17:22:30+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib:mscat: Don't use deprecated types

2021-06-09T16:54:23+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed Jun  9 16:54:23 UTC 2021 on sn-devel-184

lib:mscat: Add missing return check for error in dumpsmcat

2019-05-24T06:07:08+00:00

Found by csbuild.

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer

waf: Move gnutls_pkcs7_get_embedded_data_oid to main gnutls file

2019-04-30T23:18:27+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

build: Allow build when --disable-gnutls is set

2019-03-20T05:25:48+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13844

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Wed Mar 20 05:25:48 UTC 2019 on sn-devel-144

samba-o3: fix -Werror=maybe-uninitialized in lib/mscat/mscat_pks7.c

2019-03-08T00:42:19+00:00

samba-o3 test failed in ubuntu:1804 image with:

    ../../lib/mscat/mscat_pkcs7.c: In function ‘mscat_pkcs7_import_catfile’:
    ../../lib/mscat/mscat_pkcs7.c:143:18: error: ‘blob.length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
      mscat_data.size = blob.length;
      ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
    ../../lib/mscat/mscat_pkcs7.c:142:18: error: ‘blob.data’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
      mscat_data.data = blob.data;
      ~~~~~~~~~~~~~~~~^~~~~~~~~~~
    ../../lib/mscat/mscat_pkcs7.c: In function ‘mscat_pkcs7_verify’:
    ../../lib/mscat/mscat_pkcs7.c:225:16: error: ‘blob.length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
       ca_data.size = blob.length;
       ~~~~~~~~~~~~~^~~~~~~~~~~~~
    ../../lib/mscat/mscat_pkcs7.c:224:16: error: ‘blob.data’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
       ca_data.data = blob.data;
       ~~~~~~~~~~~~~^~~~~~~~~~~
    cc1: all warnings being treated as errors

Since in `mscat_read_file`, it may still return rc = 0 while goto error,
ends up with blob uninitialized.

Signed-off-by: Joe Guo 
Reviewed-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

lib:mscat: Use size_t for len value to fix build issue

2019-01-19T11:24:18+00:00

asn1_read_value_type() only uses it as an unsigned it, a negative value
isn't assinged.

Signed-off-by: Andreas Schneider