samba.git/lib/pthreadpool, branch talloc-2.3.2

build: Do not build selftest binaries for builds without --enable-selftest

2019-11-22T11:48:59+00:00

Add new for_selftest option to SAMBA_BINARY() and SAMBA3_BINARY()

This allows us to be much more consistent (at least in the core Samba)
and documents clearly why the binary should not be installed.

Not modified are
 - test_lp_load
 - notifyd-tests
 - gendrandperf
 - test* from examples/libsmbclient
 - dbwrap_torture
 - split_tokens
 - locktest2
 - msgtest
 - msg_sink
 - msg_source
 - versiontest
 - rpc_open_tcp
 - test_headers

As these are not tested in selftest so any change would also be
untested.  Of course they probably should be added in a different
MR.

Also not modified (because they are not tests, nor part of the
build system) are:
 - smb2mount
 - notifydd
 - log2pacp
 - debug2html
 - smbfilter
 - destroy_netlogon_creds_cli
 - spotlight2*
 - tevent_glib_tracker

These do however appear to be untested.

For now, the source4 forked client tools are left unchanged:
 - smbclient4
 - nmblookup4

Finally, the heimdal binaries are left as install=False as
they are either part of the build system or end-user tools
that we just don't want to install.  These are however tested.

The motivation is commit like c34ec003b7d45aa4196ff93a0ac29694b25e5309
and da87fa998ab71328f30bcdf5b41aee8675aee48a, which are both totally
correct but are not needed if the selftest is not run on MacOS.

There are likely other platforms or build environments where building
our test binaries is more pain than valuable, see for example also
https://lists.samba.org/archive/samba/2019-November/227137.html

Signed-off-by: Andrew Bartlett 
Reviewed-by: Isaac Boukris 

Autobuild-User(master): Isaac Boukris 
Autobuild-Date(master): Fri Nov 22 11:48:59 UTC 2019 on sn-devel-184

pthreadpool: Only link pthreadpool against librt if we have to

2019-09-25T15:39:40+00:00

This calls clock_gettime() which is available in glibc on Linux. If the
wscript in libreplace detected that librt is needed for clock_gettime()
we have to link against it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140

Signed-off-by: Andreas Schneider 
Signed-off-by: Isaac Boukris 
Pair-Programmed-With: Isaac Boukris 
Reviewed-by: Matthias Dieter Wallnöfer 
Reviewed-by: Alexander Bokovoy

pthreadpool: Remove wrong comment.

2019-08-23T23:09:12+00:00

Commit e45d33e9 removed the sync fallback path for the case that no
thread could be created. Remove the comment for that fallback as it does
not make sense anymore.

Signed-off-by: Christof Schmitt 
Reviewed-by: Ralph Böhme 

Autobuild-User(master): Christof Schmitt 
Autobuild-Date(master): Fri Aug 23 23:09:12 UTC 2019 on sn-devel-184

lib/pthreadpool: cppcheck: Fix Memory leak

2019-06-04T22:13:07+00:00

Fixes

lib/pthreadpool/tests.c:63: error: memleak: Memory leak: finished <--[cppcheck]

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

Revert "pthreadpool: split out pthreadpool_tevent_job from pthreadpool_tevent_job_state"

2019-01-11T22:11:14+00:00

This reverts commit 245d684d28dab630f3d47ff61006a1fe3e5eeefa.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

Revert "pthreadpool: add pthreadpool_tevent_job_cancel()"

2019-01-11T22:11:14+00:00

This reverts commit 791c05144ee9296024cc0fdebe4afeaaf67e26bc.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

Revert "pthreadpool: maintain a global list of orphaned pthreadpool_tevent_jobs"

2019-01-11T22:11:14+00:00

This reverts commit 25756425aaf5465e56ea809cd415b6a387848919.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

Revert "pthreadpool: add some lockless coordination between the main and job threads"

2019-01-11T22:11:14+00:00

This reverts commit 9656b8d8ee11ee351870286f16ea8fbe49112292.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

Revert "pthreadpool: add helgrind magic to PTHREAD_TEVENT_JOB_THREAD_FENCE_*()"

2019-01-11T22:11:14+00:00

This reverts commit 9b73fda926eb8493e80012794483039be66d4e6c.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

Revert "pthreadpool: maintain a list of job_states on each pthreadpool_tevent_glue"

2019-01-11T22:11:14+00:00

This reverts commit aa9b64eccfd037941512bad108c4e3946714a502.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher