samba.git/lib/replace/system/filesys.h, branch master

lib/replace: add renameat2() replacement

2024-08-21T08:02:30+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15693

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib/replace: add a replacement for openat2() that returns ENOSYS

2022-08-15T15:03:36+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

lib:replace: Only include on non-Linux systems

2022-08-02T11:05:14+00:00

Details at:
https://sourceware.org/glibc/wiki/Release/2.36#Usage_of_.3Clinux.2Fmount.h.3E_and_.3Csys.2Fmount.h.3E

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15132

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Tue Aug  2 11:05:14 UTC 2022 on sn-devel-184

Revert "lib:replace: Remove from filesys.h"

2022-08-02T10:11:35+00:00

This reverts commit 7a6bd2279897ed389d10f09e5b315a7bca96e7d4.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15132

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme

lib:replace: Remove from filesys.h

2022-07-29T13:08:36+00:00

You need to be careful if you include  or 
at least since glibc 2.36.

Details at:
https://sourceware.org/glibc/wiki/Release/2.36#Usage_of_.3Clinux.2Fmount.h.3E_and_.3Csys.2Fmount.h.3E

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15132

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri Jul 29 13:08:36 UTC 2022 on sn-devel-184

CI: add samba-no-opath

2020-12-16T09:08:30+00:00

Add a job that builds with O_PATH undefined.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

lib/replace: prefer over

2019-12-18T10:13:41+00:00

This prevents the following compile error that may happens if "system/filesys.h"
is included before "system/capability.h" on Ubuntu 16.04:

  [1802/4407] Compiling source3/lib/system.c
  In file included from ../../lib/replace/system/filesys.h:112:0,
                   from ../../source3/include/vfs.h:29,
                   from ../../source3/include/smb.h:150,
                   from ../../source3/include/includes.h:284,
                   from ../../source3/lib/system.c:23:
  /usr/include/x86_64-linux-gnu/sys/xattr.h:32:3: error: expected identifier before numeric constant
     XATTR_CREATE = 1, /* set value, fail if attr already exists.  */
     ^

The above error is from compiling a source tree which includes a change that
adds an include "system/filesys.h" to the top of "source3/include/vfs.h".

"source3/lib/system.c" has the following includes:

  #include "includes.h"
  #include "system/syslog.h"
  #include "system/capability.h"
  #include "system/passwd.h"
  #include "system/filesys.h"
  #include "../lib/util/setid.h"

The first include of "includes.h" pulls in "vfs.h" which will pull in
"system/filesys.h" with the mentioned change. "system/filesys.h" pulls in
 which has this define

  #define XATTR_CREATE  0x1

Later in "source3/lib/system.c" "system/capability.h" is included which includes
 on Ubuntu 16.04 (not in later versions of glibc). This defines the
XATTR_* values as an enum:

  enum {
    XATTR_CREATE = 1,     /* set value, fail if attr already exists.  */
    XATTR_REPLACE = 2     /* set value, fail if attr does not exist.  */
  };

The previous define of XATTR_CREATE as 1 makes this

  enum {
    1 = 1,     /* set value, fail if attr already exists.  */
    2 = 2     /* set value, fail if attr does not exist.  */
  };

which is invalid C. The compiler error diagnostic is a bit confusing, as it
prints the original enum from the include file.

See also:





Signed-off-by: Ralph Boehme 
Reviewed-by: Björn Baumbach

lib/replace: work around an API conflict between ncurses and XFS xattr API

2019-12-12T20:22:51+00:00

Compile error:

  [4530/4693] Compiling source3/utils/regedit_list.c
  In file included from ../../source3/utils/regedit_list.h:24,
                   from ../../source3/utils/regedit_list.c:20:
  /usr/include/curses.h:611:28: error: conflicting types for ‘attr_get’
    611 | extern NCURSES_EXPORT(int) attr_get (attr_t *, NCURSES_PAIRS_T *, void *); /* generated */
        |                            ^~~~~~~~
  compilation terminated due to -Wfatal-errors.

Both ncurses and XFS xattr API provide a get_attr() function. As a workaround
avoid including  if  is present.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Dec 12 20:22:51 UTC 2019 on sn-devel-184

replace: remove needless vxfs header file check

2019-02-17T12:33:12+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Uri Simchoni

replace: Use #ifdef instead of #if for config.h definitions

2018-11-28T22:19:21+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer