samba.git/lib/replace/system, branch talloc-2.3.2

ldap_server: fix hurd build

2020-08-03T09:39:02+00:00

There is no hardcoded IOV_MAX iov limitation on GNU/Hurd. We however do
not want unbound allocation, so define it to a reasonable amount.

Signed-off-by: Samuel Thibault 
Reviewed-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Aug  3 09:39:02 UTC 2020 on sn-devel-184

lib/replace: prefer over

2019-12-18T10:13:41+00:00

This prevents the following compile error that may happens if "system/filesys.h"
is included before "system/capability.h" on Ubuntu 16.04:

  [1802/4407] Compiling source3/lib/system.c
  In file included from ../../lib/replace/system/filesys.h:112:0,
                   from ../../source3/include/vfs.h:29,
                   from ../../source3/include/smb.h:150,
                   from ../../source3/include/includes.h:284,
                   from ../../source3/lib/system.c:23:
  /usr/include/x86_64-linux-gnu/sys/xattr.h:32:3: error: expected identifier before numeric constant
     XATTR_CREATE = 1, /* set value, fail if attr already exists.  */
     ^

The above error is from compiling a source tree which includes a change that
adds an include "system/filesys.h" to the top of "source3/include/vfs.h".

"source3/lib/system.c" has the following includes:

  #include "includes.h"
  #include "system/syslog.h"
  #include "system/capability.h"
  #include "system/passwd.h"
  #include "system/filesys.h"
  #include "../lib/util/setid.h"

The first include of "includes.h" pulls in "vfs.h" which will pull in
"system/filesys.h" with the mentioned change. "system/filesys.h" pulls in
 which has this define

  #define XATTR_CREATE  0x1

Later in "source3/lib/system.c" "system/capability.h" is included which includes
 on Ubuntu 16.04 (not in later versions of glibc). This defines the
XATTR_* values as an enum:

  enum {
    XATTR_CREATE = 1,     /* set value, fail if attr already exists.  */
    XATTR_REPLACE = 2     /* set value, fail if attr does not exist.  */
  };

The previous define of XATTR_CREATE as 1 makes this

  enum {
    1 = 1,     /* set value, fail if attr already exists.  */
    2 = 2     /* set value, fail if attr does not exist.  */
  };

which is invalid C. The compiler error diagnostic is a bit confusing, as it
prints the original enum from the include file.

See also:





Signed-off-by: Ralph Boehme 
Reviewed-by: Björn Baumbach

lib/replace: work around an API conflict between ncurses and XFS xattr API

2019-12-12T20:22:51+00:00

Compile error:

  [4530/4693] Compiling source3/utils/regedit_list.c
  In file included from ../../source3/utils/regedit_list.h:24,
                   from ../../source3/utils/regedit_list.c:20:
  /usr/include/curses.h:611:28: error: conflicting types for ‘attr_get’
    611 | extern NCURSES_EXPORT(int) attr_get (attr_t *, NCURSES_PAIRS_T *, void *); /* generated */
        |                            ^~~~~~~~
  compilation terminated due to -Wfatal-errors.

Both ncurses and XFS xattr API provide a get_attr() function. As a workaround
avoid including  if  is present.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Dec 12 20:22:51 UTC 2019 on sn-devel-184

replace: ensure UTIME_NOW and UTIME_OMIT are always available

2019-12-06T00:17:35+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

lib/replace: Remove libaio support

2019-10-04T18:18:40+00:00

io_uring is the way to go these days, libaio was never really useful
for Samba

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Oct  4 18:18:41 UTC 2019 on sn-devel-184

lib/replace: Remove #undef TCP_NODELAY

2019-06-18T06:47:05+00:00

A duplicate define warning is better than not defining this at all.

Similar to a patch Torsten Werner submitted to the Samba Bugzilla in
2005.

Not tested on HP-UX

reverts fc84e916f628b4fb6f6667ad45d0ced0e9134b23 that was still present in
the new copy of nis.h created in c29d087e1ea4c92717ef86e372fe80f410580fdc

BUG: https://bugzilla.samba.org/show_bug.cgi?id=2406
BUG: https://bugzilla.samba.org/show_bug.cgi?id=2140

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Jun 18 06:47:05 UTC 2019 on sn-devel-184

replace: remove needless vxfs header file check

2019-02-17T12:33:12+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Uri Simchoni

replace: only include with HAVE_POSIX_CAPABILITIES

2019-01-29T21:09:07+00:00

On FreeBSD  is a legacy wrapper to ,
which implements something different. With FreeBSD 12 including
 generates a compiler warning/error.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

replace: Fix checking for config.h #define in gssapi.h

2018-12-16T20:04:09+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer

replace: Fix checking for config.h #define in readline.h

2018-12-16T20:04:09+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer