samba.git/lib/replace/xattr.c, branch talloc-2.4.0

lib/replace - add extra check to bsd_attr_list

2023-01-02T14:27:23+00:00

The FreeBSD extattr API may return success and truncated
namelist. We need to check for this in bsd_attr_list to
ensure that we don't accidentally read off the end of the
buffer. In the case of a truncated value, the pascal
strings for attr names will reflect the lengths as if
the value were not truncated. For example:
`58DosStrea`

In case of short read we now set error to ERANGE and
fail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15271

Signed-off-by: Andrew Walker 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Jan  2 14:27:23 UTC 2023 on sn-devel-184

lib: Align an integer type

2022-08-04T20:44:32+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib/replace/xattr.c: typo fixes

2019-10-31T00:43:36+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Martin Schwenke

replace/setxattr: correctly use our flags on Darwin

2019-08-29T17:10:32+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Björn Jacke 
Autobuild-Date(master): Thu Aug 29 17:10:32 UTC 2019 on sn-devel-184

xattr/setxattr: fix flag support on AIX

2019-08-29T15:53:30+00:00

AIX requires the flags to be 0, we need to do those checks manually.

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

replace/setxattr: set reasonable and unified errno value in case the EA value was too big

2019-08-29T15:53:30+00:00

FreeBSD and AIX already set errno to ENAMETOOLONG, this is what we should map
other platforms also to to finally map to the correct NT error code also.

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

build: bundle and reduce huge number of EA function tests

2018-07-03T11:24:51+00:00

It's sufficient to check for one basic function of an EA implementation and a
use a single ifdef for each group of EA functions. This makes more sense than
checking for each EA function on each platform.

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Jul  3 13:24:51 CEST 2018 on sn-devel-144

lib/replace: validate xattr namespace prefix on FreeBSD

2017-02-10T17:33:17+00:00

We should validate the xattr name string ensuring it either begins with
"sytem." or "user.". If it doesn't, we should fail the request with
EINVAL.

The FreeBSD xattr API uses namespaces but doesn't put the namespace name
as a string prefix at the beginning of the xattr name. It gets passed as
an additional int arg instead.

On the other hand, our libreplace xattr API expects the caller to put a
namespace prefix into the xattr name.

Unfortunately the conversion and stripping of the namespace string prefix
from the xattr name gives the following unexpected result on FreeBSD:

rep_setxattr("foo.bar", ...) => xattr with name "bar"

The code checks if the name begins with "system.", if it doesn't find
it, it defaults to the user namespace and then does a strchr(name, '.')
which skips *any* leading string before the first dot.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12490

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

replace: Fix developer build on BSD.

2013-11-21T02:37:59+00:00

This fixes bsd_attr_list() calling geteuid().

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Nov 21 03:37:59 CET 2013 on sn-devel-104

xattr: fix listing EAs on *BSD for non-root users

2013-11-08T19:43:29+00:00

Thanks to Stefan Rompf for reporting.

This fixes bug #10247

Signed-off-by: Bjoern Jacke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Nov  8 20:43:30 CET 2013 on sn-devel-104