samba.git/lib/replace, branch talloc-2.1.6

libreplace: Only check for malloc.h if needed

2015-11-19T06:01:09+00:00

OpenBSD complains that malloc.h is deprecated on every gcc invocation.
That hides a lot of real warnings. malloc and friends nowadays are
typically defined in stdlib.h, only check there.

We need memalign. On OpenBSD this does not exist, so libreplace replaces
it. The wscript test in libreplace only checks whether memalign can
link. Unfortunately in glibc memalign comes from malloc.h.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

libreplace: Put the malloc.h check on a line of its own

2015-11-19T06:01:09+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

libreplace: Only check malloc.h once

2015-11-19T06:01:09+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

build:wafsamba: Remove samba_utils.runonce

2015-11-06T09:37:24+00:00

The decorator order matters in the following:
"""
@runonce
@conf
function()
"""

First, the @conf decorator binds the function to the configuration context
and then returns the same function. The @runonce decorator then takes
the output function and replaces it by another that performs caching. This new
function remains in the current script and is never bound to the configuration
context, so caching never occurs.

The declaration would have been correct if written like this:
"""
@conf
@runonce
function()
"""

Yet the decorator @run_once does not keep the function name (__name__), so the
annotation with @conf would fail. The straightforward approach is to remove
all the incorrect @runonce occurrences.

Besides that, the function Utils.run_once is already present in the Waf library,
and is sufficient for the current needs of the Samba code (it caches only the
first argument). Therefore samba_utils.runonce can be safely replaced by
Utils.run_once, which is also present in Waf 1.8.

Note: at runtime, only SETUP_BUILD_GROUPS seems to actually use caching.

Signed-off-by: Thomas Nagy 
Reviewed-by: Uri Simchoni uri@samba.org
Reviewed-by: Andrew Bartlett

lib/replace: Make sure that replacement strto[u]ll does not reset errno unexpectedly

2015-10-31T21:03:14+00:00

Fix the replacement functions for strtoll and strtoull to not set errno
to 0 if errno is EINVAL before calling, strto[u]ll does not modify errno
and the base is ok.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11455

Signed-off-by: Felix Janda 
Reviewed-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

lib/replace: Replace BSD strtoull by wrapping strtoull instead of strtouq

2015-10-31T21:03:14+00:00

Same as commit e50bf6d537ef09e936d19d6e0bf63f9bbc5d4818 but for strtoull
instead of strtoll.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11455

Signed-off-by: Felix Janda 
Reviewed-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

build:wafsamba: dead code removal in gettext detection

2015-10-27T02:34:28+00:00

Since the --gettext-location command-line option has no effect, the misleading
code is removed. The samba functions ADD_CFLAGS must also be used in the future

Signed-off-by: Thomas Nagy 
Reviewed-by: Uri Simchoni 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Oct 27 03:34:28 CET 2015 on sn-devel-104

libreplace: Fix the build on Solaris

2015-10-01T00:55:21+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Michael Adam

replace: Fix check for gettimeofday()

2015-09-09T22:36:16+00:00

The check does not include  the test might fail with a
implicit function declaration error.

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Sep 10 00:36:16 CEST 2015 on sn-devel-104

replace: Fix bug 11455

2015-08-19T09:22:38+00:00

Don't call rep_strtoull recursively

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11455

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Wed Aug 19 11:22:38 CEST 2015 on sn-devel-104