samba.git/lib/replace, branch talloc-2.4.4

Fix clang 20 format-truncation warnings

2025-05-28T23:04:38+00:00

Fix:
  lib/replace/tests/testsuite.c:387:6: error:
    'snprintf' will always be truncated; specified size is 3,
    but format string expands to at least 5 [-Werror,-Wformat-truncation]
  387 |         if (snprintf(tmp, 3, "foo%d", 9) != 4) {
      |             ^

As this is an explicit test of snprintf's truncation behaviour
the warning can be safely suppressed.

Signed-off-by: Gary Lockyer 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Anoop C S

replace: fix hex_upper -> hexchars_upper

2025-03-27T13:13:31+00:00

It seems we don't have many systems without a working snprintf anymore...

Signed-off-by: Bjoern Jacke 
Reviewed-by: Volker Lendecke 
Reviewed-by: Anoop C S

lib:replace: Don't use deprecated readline CPPFunction cast

2025-01-21T19:38:36+00:00

HAVE_RL_COMPLETION_FUNC_T was unused and not checking for the right
function.

libcli/smbreadline/smbreadline.c: In function ‘smb_readline’:
libcli/smbreadline/smbreadline.c:139:17: warning: ‘CPPFunction’ is deprecated [-Wdeprecated-declarations]
  139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libcli/smbreadline/smbreadline.c:139:50: error: assignment to ‘char ** (*)(const char *, int,  int)’ from incompatible pointer type ‘char ** (*)(void)’ [-Wincompatible-pointer-types]
  139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
      |                                                  ^

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15788

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Jan 21 19:38:37 UTC 2025 on atb-devel-224

lib:replace: Remove trailing spaces from readline.h

2025-01-21T18:40:36+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15788

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy

remove usage of bzero

2025-01-02T17:01:30+00:00

bzero() function has been deprecated for a long time.
In samba it is replaced with memset().  But samba also
provides common memory-zeroing macros, like ZERO_STRUCT().
In all places where bzero() is used, it actually meant to
zero a structure or an array.

So replace these bzero() calls with ZERO_STRUCT() or
ZERO_ARRAY() as appropriate, and remove bzero() replacement
and testing entirely.

While at it, also stop checking for presence of memset() -
this function is standard for a very long time, and the
only conditional where HAVE_MEMSET were used, was to
provide replacement for bzero() - in all other places
memset() is used unconditionally.

Signed-off-by: Michael Tokarev 
Reviewed-by: Andreas Schneider 
Reviewed-by: Pavel Filipenský

libreplace: Introduce hexchars_{upper|lower}

2024-11-12T12:09:35+00:00

We use that in quite a few places in our code.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

lib/replace: memset_explicit() only takes three arguments

2024-11-11T16:47:46+00:00

Signed-off-by: Thomas Klausner 
Reviewed-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Mon Nov 11 16:47:46 UTC 2024 on atb-devel-224

lib/replace: add renameat2() replacement

2024-08-21T08:02:30+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15693

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

libreplace: add rep_copy_reflink()

2024-08-20T05:41:32+00:00

FICLONERANGE was introduced in kernel version 4.5, so I guess we can just assume
it is present if HAVE_LINUX_IOCTL is defined.

Signed-off-by: Ralph Boehme 
Reviewed-by: David Disseldorp

lib/replace: make sure krb5_cc_default[_name]() is no longer used directly

2024-05-14T11:22:28+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Tue May 14 11:22:28 UTC 2024 on atb-devel-224