samba.git/lib/socket/interfaces.c, branch talloc-2.1.7

lib/socket/interfaces: Fix some uninitialied bytes.

2016-03-12T05:24:24+00:00

Valgrind reports the following:

==26599== Syscall param ioctl(SIOCETHTOOL) points to uninitialised byte(s)
==26599==    at 0x7014707: ioctl (in /usr/lib64/libc-2.22.so)
==26599==    by 0x79D1585: query_iface_speed_from_name (interfaces.c:152)
==26599==    by 0x79D1BBA: _get_interfaces (interfaces.c:277)
==26599==    by 0x79D1E80: get_interfaces (interfaces.c:368)
==26599==    by 0x508A7E3: load_interfaces (interface.c:612)
==26599==    by 0x150B30: main (net.c:963)
==26599==  Address 0xffefff0d8 is on thread 1's stack
==26599==  in frame #1, created by query_iface_speed_from_name
(interfaces.c:130)
==26599==
==26599== Syscall param ioctl(SIOCETHTOOL) points to uninitialised byte(s)
==26599==    at 0x7014707: ioctl (in /usr/lib64/libc-2.22.so)
==26599==    by 0x79D15CC: query_iface_speed_from_name (interfaces.c:164)
==26599==    by 0x79D1BBA: _get_interfaces (interfaces.c:277)
==26599==    by 0x79D1E80: get_interfaces (interfaces.c:368)
==26599==    by 0x508A7E3: load_interfaces (interface.c:612)
==26599==    by 0x150B30: main (net.c:963)
==26599==  Address 0xffefff0d8 is on thread 1's stack
==26599==  in frame #1, created by query_iface_speed_from_name
(interfaces.c:130)

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Jeremy Allison

lib/socket: Fix improper use of default interface speed

2016-02-13T15:22:22+00:00

_get_interfaces() function from interfaces.c uses if_speed
variable to store interface speed and is initialized with a
default value at start. But if_speed populated via one
iteration for a specific IP address will be treated as the
default value for next iteration which is wrong. Therefore
change is to move the initialization cum declaration of
if_speed inside iteration of IP addresses loop.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11734

Signed-off-by: Anoop C S 
Reviewed-by: Michael Adam 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Sat Feb 13 16:22:22 CET 2016 on sn-devel-144

lib:socket: fix CID 1350009 - illegal memory accesses (BUFFER_SIZE_WARNING)

2016-02-13T12:14:13+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11735

Pair-Programmed-With: Guenther Deschner 

Signed-off-by: Michael Adam 
Signed-off-by: Guenther Deschner 
Reviewed-by: Uri Simchoni

lib:socket: fix CID 1350010 - integer OVERFLOW_BEFORE_WIDEN

2016-02-03T23:35:10+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Feb  4 00:35:11 CET 2016 on sn-devel-144

lib:socket: detect link speed with ethtool ioctl in get_interfaces (on linux)

2016-01-26T06:33:16+00:00

Pair-Programmed-With: Michael Adam 

Signed-off-by: Anoop C S 
Signed-off-by: Michael Adam 
Reviewed-by: Stefan Metzmacher

lib:socket: set defaults for linkspeed and capability in get_interfaces()

2016-01-26T06:33:16+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Stefan Metzmacher

lib:socket: get interface index from kernel

2016-01-26T06:33:16+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Stefan Metzmacher

Fix bug # 9666 - Broken filtering of link-local addresses.

2013-02-28T19:56:57+00:00

This patch should address the problem with Link Local addresses
on FreeBSD and Linux.

Reviewed-by: Jeremy Allison 
Reviewed-by: Richard Sharpe 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Feb 28 20:56:57 CET 2013 on sn-devel-104

Start to add truncate checks on all uses of strlcpy(). Reading lwn

2012-03-29T18:48:15+00:00

has it's uses :-).

Autobuild-User: Jeremy Allison 
Autobuild-Date: Thu Mar 29 20:48:15 CEST 2012 on sn-devel-104

Fix const warnings.

2011-10-14T20:48:53+00:00