samba.git/lib/socket/interfaces.c, branch talloc-2.4.4

lib/socket: rearrange iface_comp() to use NUMERIC_CMP

2024-04-23T01:33:29+00:00

We rearrange rather than just replacing the subtraction, because that
would call ntohl() more than necessary, and I think the flow is a bit
clearer this way.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

lib:socket: Add missing newlines to logging messages

2023-08-08T04:39:37+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:socket: Fix code spelling

2023-04-14T05:25:33+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Joseph Sutton

lib/socket: autodetect RSS using ETHTOOL_GRXRINGS

2020-05-07T14:44:40+00:00

This is also used as part of 'ethtool -n rdma14' and
'ethtool -x rdma14'.

;#> ethtool -n rdma14
8 RX rings available
rxclass: Cannot get RX class rule count: Operation not supported
RX classification rule retrieval failed

;#> ethtool -x rdma14
RX flow hash indirection table for rdma14 with 8 RX ring(s):
    0:      0     1     2     3     4     5     6     7
    8:      0     1     2     3     4     5     6     7
RSS hash key:
Operation not supported
RSS hash function:
    toeplitz: on
    xor: off
    crc32: off

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib/socket: let query_iface_speed_from_name() initialize memory passed to syscalls

2020-05-07T14:44:39+00:00

I'm not sure if struct initializers would take care of padding,
so I use ZERO_STRUCT().

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib:socket: If returning early, set ifaces

2018-10-27T22:35:34+00:00

Prevents a segfault in load_interfaces() when total interfaces == 1.
Fixes regression caused by da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13665

Signed-off-by: David Mulder 
Reviewed-by: Ralph Böhme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Sun Oct 28 00:35:35 CEST 2018 on sn-devel-144

lib:socket: Return early if we have only one interface

2018-03-20T22:16:16+00:00

This fixes compilation with -Wstrict-overflow=2

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

libsocket: Make sure ifr.ifr_name is null-terminated

2016-12-03T02:40:53+00:00

Found by Coverity

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Dec  3 03:40:53 CET 2016 on sn-devel-144

lib/socket/interfaces: Fix some uninitialied bytes.

2016-03-12T05:24:24+00:00

Valgrind reports the following:

==26599== Syscall param ioctl(SIOCETHTOOL) points to uninitialised byte(s)
==26599==    at 0x7014707: ioctl (in /usr/lib64/libc-2.22.so)
==26599==    by 0x79D1585: query_iface_speed_from_name (interfaces.c:152)
==26599==    by 0x79D1BBA: _get_interfaces (interfaces.c:277)
==26599==    by 0x79D1E80: get_interfaces (interfaces.c:368)
==26599==    by 0x508A7E3: load_interfaces (interface.c:612)
==26599==    by 0x150B30: main (net.c:963)
==26599==  Address 0xffefff0d8 is on thread 1's stack
==26599==  in frame #1, created by query_iface_speed_from_name
(interfaces.c:130)
==26599==
==26599== Syscall param ioctl(SIOCETHTOOL) points to uninitialised byte(s)
==26599==    at 0x7014707: ioctl (in /usr/lib64/libc-2.22.so)
==26599==    by 0x79D15CC: query_iface_speed_from_name (interfaces.c:164)
==26599==    by 0x79D1BBA: _get_interfaces (interfaces.c:277)
==26599==    by 0x79D1E80: get_interfaces (interfaces.c:368)
==26599==    by 0x508A7E3: load_interfaces (interface.c:612)
==26599==    by 0x150B30: main (net.c:963)
==26599==  Address 0xffefff0d8 is on thread 1's stack
==26599==  in frame #1, created by query_iface_speed_from_name
(interfaces.c:130)

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Jeremy Allison

lib/socket: Fix improper use of default interface speed

2016-02-13T15:22:22+00:00

_get_interfaces() function from interfaces.c uses if_speed
variable to store interface speed and is initialized with a
default value at start. But if_speed populated via one
iteration for a specific IP address will be treated as the
default value for next iteration which is wrong. Therefore
change is to move the initialization cum declaration of
if_speed inside iteration of IP addresses loop.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11734

Signed-off-by: Anoop C S 
Reviewed-by: Michael Adam 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Sat Feb 13 16:22:22 CET 2016 on sn-devel-144