samba.git/lib/socket, branch talloc-2.3.0

lib:socket: If returning early, set ifaces

2018-10-27T22:35:34+00:00

Prevents a segfault in load_interfaces() when total interfaces == 1.
Fixes regression caused by da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13665

Signed-off-by: David Mulder 
Reviewed-by: Ralph Böhme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Sun Oct 28 00:35:35 CEST 2018 on sn-devel-144

lib:socket: Return early if we have only one interface

2018-03-20T22:16:16+00:00

This fixes compilation with -Wstrict-overflow=2

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

Add explicit dependency on samba-debug from libinterfaces and libserverrole.

2017-01-23T07:26:43+00:00

Currently these dependencies are indirect via a SAMBA_SUBSYSTEM
which does not propagate private library information. This results
in these 2 libraries getting generated with no RPATH information
in the ELF header.

Additional discussion [1].

[1] -
https://lists.samba.org/archive/samba-technical/2017-January/118078.html

Signed-off-by: Zentaro Kavanagh 
Reviewed-by: Ralph Böhme 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Jan 23 08:26:43 CET 2017 on sn-devel-144

libsocket: Make sure ifr.ifr_name is null-terminated

2016-12-03T02:40:53+00:00

Found by Coverity

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Dec  3 03:40:53 CET 2016 on sn-devel-144

lib/socket/interfaces: Fix some uninitialied bytes.

2016-03-12T05:24:24+00:00

Valgrind reports the following:

==26599== Syscall param ioctl(SIOCETHTOOL) points to uninitialised byte(s)
==26599==    at 0x7014707: ioctl (in /usr/lib64/libc-2.22.so)
==26599==    by 0x79D1585: query_iface_speed_from_name (interfaces.c:152)
==26599==    by 0x79D1BBA: _get_interfaces (interfaces.c:277)
==26599==    by 0x79D1E80: get_interfaces (interfaces.c:368)
==26599==    by 0x508A7E3: load_interfaces (interface.c:612)
==26599==    by 0x150B30: main (net.c:963)
==26599==  Address 0xffefff0d8 is on thread 1's stack
==26599==  in frame #1, created by query_iface_speed_from_name
(interfaces.c:130)
==26599==
==26599== Syscall param ioctl(SIOCETHTOOL) points to uninitialised byte(s)
==26599==    at 0x7014707: ioctl (in /usr/lib64/libc-2.22.so)
==26599==    by 0x79D15CC: query_iface_speed_from_name (interfaces.c:164)
==26599==    by 0x79D1BBA: _get_interfaces (interfaces.c:277)
==26599==    by 0x79D1E80: get_interfaces (interfaces.c:368)
==26599==    by 0x508A7E3: load_interfaces (interface.c:612)
==26599==    by 0x150B30: main (net.c:963)
==26599==  Address 0xffefff0d8 is on thread 1's stack
==26599==  in frame #1, created by query_iface_speed_from_name
(interfaces.c:130)

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Jeremy Allison

lib/socket: Fix improper use of default interface speed

2016-02-13T15:22:22+00:00

_get_interfaces() function from interfaces.c uses if_speed
variable to store interface speed and is initialized with a
default value at start. But if_speed populated via one
iteration for a specific IP address will be treated as the
default value for next iteration which is wrong. Therefore
change is to move the initialization cum declaration of
if_speed inside iteration of IP addresses loop.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11734

Signed-off-by: Anoop C S 
Reviewed-by: Michael Adam 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Sat Feb 13 16:22:22 CET 2016 on sn-devel-144

lib:socket: fix CID 1350009 - illegal memory accesses (BUFFER_SIZE_WARNING)

2016-02-13T12:14:13+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11735

Pair-Programmed-With: Guenther Deschner 

Signed-off-by: Michael Adam 
Signed-off-by: Guenther Deschner 
Reviewed-by: Uri Simchoni

lib:socket: fix CID 1350010 - integer OVERFLOW_BEFORE_WIDEN

2016-02-03T23:35:10+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Feb  4 00:35:11 CET 2016 on sn-devel-144

lib:socket: detect link speed with ethtool ioctl in get_interfaces (on linux)

2016-01-26T06:33:16+00:00

Pair-Programmed-With: Michael Adam 

Signed-off-by: Anoop C S 
Signed-off-by: Michael Adam 
Reviewed-by: Stefan Metzmacher

build: detect support for ethtool

2016-01-26T06:33:16+00:00

Pair-Programmed-With: Anoop C S 

Signed-off-by: Michael Adam 
Signed-off-by: Anoop C S 
Reviewed-by: Stefan Metzmacher