samba.git/lib/talloc/pytalloc_util.c, branch talloc-2.3.0

talloc/py_util: remove tautologically dead code

2019-07-22T22:20:25+00:00

Being careful is good and all, but if we don't trust the

       static PyTypeObject *type = NULL;

two lines up, we need to reconsider our entire software universe.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

talloc: pytalloc_get_checked_type: survive non-talloc objects

2019-07-22T22:20:25+00:00

If the python object is not a talloc object, we will end up
with a NULL pointer. We weren't checking for that properly

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

talloc: add pytalloc_get_name() helper

2019-07-22T22:20:25+00:00

In several places we go

   talloc_get_name(pytalloc_get_ptr(py_obj))

which is a certain NULL derefernce if py_obj is not a talloc object.

This is a helper function that chooses to say "non-talloc object"
rather than crash.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

pytalloc: Handle memory errors when creating pytalloc objects.

2019-03-26T03:03:23+00:00

Don't create superfluous exceptions.

Signed-off-by: Kristján Valur 
Reviewed-by: Noel Power 
Reviewed-by: Andrew Bartlett

pytalloc: Further refactoring to eliminate duplicate code.

2019-03-26T03:03:23+00:00

Signed-off-by: Kristján Valur 
Reviewed-by: Noel Power 
Reviewed-by: Andrew Bartlett

pytalloc: Refactor the pytalloc_reference and pytalloc_steal to use a common method.

2019-03-26T03:03:23+00:00

Signed-off-by: Kristján Valur 
Reviewed-by: Noel Power 
Reviewed-by: Andrew Bartlett

pytalloc: Remove deprecated pytalloc_CObject_FromTallocPtr()

2019-03-21T04:06:14+00:00

This function makes it harder to remove the --extra-python handlers and is only
provided for Python 2.x, support for which Samba is removing.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

pytalloc: add pytalloc_GenericObject_{steal,reference}[_ex]()

2017-02-25T01:39:11+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

pytalloc: Add pytalloc_BaseObject_PyType_Ready() wrapper

2016-03-08T00:58:29+00:00

This avoids the need for the caller to set tp_base and tp_basicsize and
so removes those as possible errors.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam

pytalloc: Add new BaseObject

2016-03-08T00:58:26+00:00

This new object not only avoids the ABI issues of talloc.Object
it stores one more pointer, being the start of the array, and
so can be used to fix the PIDL bindings/talloc refcount issue.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam