samba.git/lib/talloc/pytalloc_util.c, branch talloc-2.4.3

Use python.h from libreplace

2023-11-20T15:37:33+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15513

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

lib:talloc: Fix code spelling

2023-04-14T05:25:33+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Joseph Sutton

Bug 9931: change pytalloc source to LGPL

2021-03-16T18:17:42+00:00

pytalloc is currently GPL, while the rest of talloc is LGPL.

This situation arose because pytalloc was originally developed under
source4/scripting/python/, and moved into talloc proper with commit
0f043c197c473c801fc32c727194b5a2d6ae232f ("Move pytalloc to talloc
directory.", October 2008).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9931

Signed-off-by: David Disseldorp 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Björn Jacke 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Mar 16 18:17:43 UTC 2021 on sn-devel-184

lib/talloc: clang: Fix 'Value stored during its initialization is never read'

2019-09-26T18:41:27+00:00

Fixes:

ib/talloc/pytalloc_util.c:245:8: warning: Value stored to 'type_obj' during its initialization is never read <--[clang]
        void *type_obj = talloc_check_name(ptr, type_name);
              ^~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

talloc/py_util: remove tautologically dead code

2019-07-22T22:20:25+00:00

Being careful is good and all, but if we don't trust the

       static PyTypeObject *type = NULL;

two lines up, we need to reconsider our entire software universe.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

talloc: pytalloc_get_checked_type: survive non-talloc objects

2019-07-22T22:20:25+00:00

If the python object is not a talloc object, we will end up
with a NULL pointer. We weren't checking for that properly

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

talloc: add pytalloc_get_name() helper

2019-07-22T22:20:25+00:00

In several places we go

   talloc_get_name(pytalloc_get_ptr(py_obj))

which is a certain NULL derefernce if py_obj is not a talloc object.

This is a helper function that chooses to say "non-talloc object"
rather than crash.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

pytalloc: Handle memory errors when creating pytalloc objects.

2019-03-26T03:03:23+00:00

Don't create superfluous exceptions.

Signed-off-by: Kristján Valur 
Reviewed-by: Noel Power 
Reviewed-by: Andrew Bartlett

pytalloc: Further refactoring to eliminate duplicate code.

2019-03-26T03:03:23+00:00

Signed-off-by: Kristján Valur 
Reviewed-by: Noel Power 
Reviewed-by: Andrew Bartlett

pytalloc: Refactor the pytalloc_reference and pytalloc_steal to use a common method.

2019-03-26T03:03:23+00:00

Signed-off-by: Kristján Valur 
Reviewed-by: Noel Power 
Reviewed-by: Andrew Bartlett