samba.git/lib/talloc/talloc.c, branch talloc-2.0.8

talloc: Convert error cecking macros into fns

2012-10-05T21:24:17+00:00

This will avoid 'surprise returns' and makes the code cleare to readers.
These macros were complex enough to warrant a full function anyway not
just for readability but also for debuggability.

Thanks David for pointing out this issue.

Autobuild-User(master): Simo Sorce 
Autobuild-Date(master): Fri Oct  5 23:24:17 CEST 2012 on sn-devel-104

Add memory limiting capability to talloc

2012-10-05T03:57:17+00:00

By calling talloc_set_memlimit() we can now set a max memory limit
for a whole talloc hierarchy.
ANy attempt to allocate memory beyond the max allowed for the whole
hierarchy wil cause an allocation failure.

Stealing memory correctly accounts for used memory in the old and the new
hierarchy but exceeding the memory limit in the new parent will not cause
a failure.

talloc: don't allow a talloc_pool inside a talloc_pool.

2012-07-17T19:24:31+00:00

We explicitly call free() on a pool which falls to zero, assuming it's
not inside another pool (we crash).  Check on creation and explicitly
document this case.

Signed-off-by: Rusty Russell

talloc: use a struct for pool headers.

2012-07-17T19:23:31+00:00

This neatens the code a bit (we should do a similar thing for all the
TALLOC_CHUNK macros).

Two subtler changes:
(1) As a result of the struct, we actually pack object_count into the 
    talloc header on 32-bit platforms (since the header is 40 bytes, but
    needs to be 16-byte aligned).
(2) I avoid VALGRIND_MAKE_MEM_UNDEFINED on memmove when we resize the
    only entry in a pool; that's done later anyway.

With -O2 on my 11.04 Ubuntu 32-bit x86 laptop, the talloc_pool speed as
measured by testsuite.c actually increases 10%.

Signed-off-by: Rusty Russell

talloc: Fix copy&paste errors

2012-04-24T11:28:44+00:00

talloc: Slightly simplify talloc_unlink

2012-01-02T18:07:23+00:00

Nested if's are hard to understand to me.

Signed-off-by: Stefan Metzmacher 

Autobuild-User: Volker Lendecke 
Autobuild-Date: Mon Jan  2 19:07:23 CET 2012 on sn-devel-104

talloc: Fix a typo

2012-01-02T13:59:59+00:00

talloc: fix a comment typo

2011-10-26T00:44:02+00:00

talloc: Remove an unused variable

2011-09-07T14:47:26+00:00

Autobuild-User: Volker Lendecke 
Autobuild-Date: Wed Sep  7 16:47:26 CEST 2011 on sn-devel-104

talloc: ensure the sibling linked list remains valid during a free

2011-08-08T23:53:16+00:00

This ensures that the sibling list of a pointer doesn't become invalid
during a free operation. It is an alternative fix to the fix in
6f51a1f45bf4de062cce7a562477e8140630a53d, and avoids the problem of
trying to calculate the parent pointer early

This should fix the subtle spoolss talloc bug that Simo found

Autobuild-User: Andrew Tridgell 
Autobuild-Date: Tue Aug  9 01:53:17 CEST 2011 on sn-devel-104