samba.git/lib/talloc/talloc.c, branch talloc-2.1.2

talloc: fix _talloc_total_limit_size prototype

2015-03-09T08:35:05+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib: talloc: Allow destructors to reparent the object they're called on.

2015-03-08T17:24:07+00:00

If a destructor returns failure (-1) when freeing a child, talloc
must then reparent the child.

Firstly it tries the owner of any reference, next the parent of the
current object calling _talloc_free_children_internal(), and finally
the null context in the last resort.

If a destructor reparented its own object, which can be a very
desirable thing to do (a destructor can make a decision it isn't
time to die yet, and as the parent may be going away it might
want to move itself to longer-term storage) then this new parent
gets overwritten by the existing reparenting logic.

This patch checks when freeing a child if it already reparented
itself, and if it did doesn't then overwrite the new parent.

Makes destructors more flexible.

Signed-off-by: Jeremy Allison 
Reviewed-by: Volker Lendecke 
Reviewed-by: Ira Cooper

lib: talloc: Fix bug when calling a destructor.

2015-03-08T17:24:06+00:00

If the destructor itself calls talloc_set_destructor()
and returns -1, the new destructor set is overwritten
by talloc.

Dectect that and leave the new destructor in place.

Signed-off-by: Jeremy Allison 
Reviewed-by: Ira Cooper

talloc: fix compiler warning

2014-05-16T15:21:04+00:00

This avoids the following warning when using:

CFLAGS="-O3 -g -fstrict-overflow -Wstrict-overflow=5"

../talloc.c: In Funktion »talloc_is_parent«:
../talloc.c:2658:21: Warnung: assuming signed overflow does not occur when
changing X +- C1 cmp C2 to X cmp C1 +- C2 [-Wstrict-overflow]

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

talloc: inline talloc_get_name()

2014-05-16T15:21:04+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

talloc: inline more static functions

2014-05-16T15:21:04+00:00

We need the code to be as fast as possible.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

talloc: Tune talloc_vasprintf

2014-05-15T10:49:14+00:00

vsnprintf is significantly more expensive than memcpy. For the
common case where the string we print is less than a kilobyte, avoid
the second vsnprintf.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu May 15 12:49:14 CEST 2014 on sn-devel-104

talloc: Add talloc_pooled_object

2013-09-08T09:34:06+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

talloc: Allow nested pools.

2013-09-08T09:34:06+00:00

Signed-off-by: Volker Lendecke 
Signed-off-by: Jeremy Allison

talloc: Add a separate pool size

2013-09-08T09:34:06+00:00

This is necessary to allow talloc pools to be objects on their own. It
is an incompatible change in the sense that talloc_get_size(pool) now
returns 0 instead of the pool size. When the talloc_pooled_object()
call is added, this will start to make sense again.

Maybe we should add a talloc_pool_size call? Or is that overkill?

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 
Reviewed-by: Stefan Metzmacher