samba.git/lib/talloc/talloc.c, branch talloc-2.4.0

lib/talloc: Zero-initialise chunk pointers

2023-01-10T20:22:32+00:00

Ensuring pointers are always initialised avoids compilation errors with
FORTIFY_SOURCE=2.

Signed-off-by: Joseph Sutton 
Reviewed-by: Jeremy Allison

lib: Move talloc_asprintf_addbuf() to talloc

2022-12-14T04:32:34+00:00

I wanted to use this in debug.c, but this would have meant to pollute
debug's deps with a lot of stuff. Also, looking through uses of
talloc_asprint_append(), very many of those don't do NULL checks
properly and could benefit from the _addbuf() flavor. We can add a
vasprintf variant later if the need shows up.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: talloc: Remove the ALWAYS_REALLOC code paths.

2020-11-10T19:49:33+00:00

This is now never set, and also never tested, and only makes
the talloc code more complicated.

Once this is gone we can start looking at the memlimit
stuff.

Signed-off-by: Jeremy Allison 
Reviewed-by: Alexander Bokovoy

talloc: alternatively use prama init for constructors if supported

2020-11-10T06:53:43+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

lib: talloc: Fix memlimit on pool realloc.

2020-11-09T02:46:50+00:00

We only have to do the memlimit check before any
real malloc or realloc. Allocations out of a
memory pool have already been counted in the
memory limit, so don't check in those cases.

This is an application-visible change (although
fixing a bug) so bump the ABI to 2.3.1 -> 2.3.2.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14540

Signed-off-by: Jeremy Allison 
Signed-off-by: Arran Cudbard-Bell 
Reviewed-by: Andrew Bartlett

lib: talloc: Fix pool object accounting when doing talloc_realloc() in the ALWAYS_REALLOC compiled case.

2020-11-09T02:46:49+00:00

tc_alloc_pool() or the fallback malloc can return NULL.

Wait until we know we are returning a valid pointer
before decrementing pool_hdr->object_count due to
reallocing out of the talloc_pool.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14540

Signed-off-by: Jeremy Allison 
Reviewed-by: Andrew Bartlett

lib: talloc: Cleanup. Use consistent preprocessor logic macros.

2020-11-09T02:46:49+00:00

Match other use of ALWAYS_REALLOC.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14540

Signed-off-by: Jeremy Allison 
Reviewed-by: Andrew Bartlett

talloc: Mark ptr of talloc_unlink() not as a tainted scalar

2020-06-09T16:02:59+00:00

This should address a lot of issues reported by Coverity.

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke

talloc: Fix alignment issues for casting pointers

2019-03-19T12:38:50+00:00

warning: cast from 'char *' to 'struct talloc_chunk *' increases required
alignment from 1 to 8

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Mar 19 12:38:50 UTC 2019 on sn-devel-144

lib:talloc: Fix undefined behavior in talloc_memdup

2018-12-12T17:34:10+00:00

lib/talloc/talloc.c:2419: runtime error: null pointer passed as argument
2, which is declared to never be null

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke