samba.git/lib/talloc, branch talloc-2.3.2

lib: talloc: Remove the ALWAYS_REALLOC code paths.

2020-11-10T19:49:33+00:00

This is now never set, and also never tested, and only makes
the talloc code more complicated.

Once this is gone we can start looking at the memlimit
stuff.

Signed-off-by: Jeremy Allison 
Reviewed-by: Alexander Bokovoy

talloc: alternatively use prama init for constructors if supported

2020-11-10T06:53:43+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

talloc/pytalloc: fix studio compler build

2020-11-10T06:53:43+00:00

Solaris Studio compiler 12.4 is pedantic about prototypes in headers having
the external visibility declarations too. It throws errors like:

redeclaration must have the same or more restrictive linker scoping: ...

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

talloc: fix studio compiler build

2020-11-10T06:53:43+00:00

Solaris Studio compiler 12.4 is pedantic about prototypes in headers having
the external visibility declarations too. It throws errors like:

redeclaration must have the same or more restrictive linker scoping: ...

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

lib: talloc: More tests for realloc when used with memlimited pools

2020-11-09T02:46:50+00:00

This requires the previous patch.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14540

Signed-off-by: Arran Cudbard-Bell 
Reviewed-by: Jeremy Allison 
Reviewed-by: Andrew Bartlett

lib: talloc: Fix memlimit on pool realloc.

2020-11-09T02:46:50+00:00

We only have to do the memlimit check before any
real malloc or realloc. Allocations out of a
memory pool have already been counted in the
memory limit, so don't check in those cases.

This is an application-visible change (although
fixing a bug) so bump the ABI to 2.3.1 -> 2.3.2.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14540

Signed-off-by: Jeremy Allison 
Signed-off-by: Arran Cudbard-Bell 
Reviewed-by: Andrew Bartlett

lib: talloc: Add more debugging text for existing memlimit + pool tests

2020-11-09T02:46:49+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14540

Signed-off-by: Arran Cudbard-Bell 
Reviewed-by: Jeremy Allison 
Reviewed-by: Andrew Bartlett

lib: talloc: Fix pool object accounting when doing talloc_realloc() in the ALWAYS_REALLOC compiled case.

2020-11-09T02:46:49+00:00

tc_alloc_pool() or the fallback malloc can return NULL.

Wait until we know we are returning a valid pointer
before decrementing pool_hdr->object_count due to
reallocing out of the talloc_pool.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14540

Signed-off-by: Jeremy Allison 
Reviewed-by: Andrew Bartlett

lib: talloc: Cleanup. Use consistent preprocessor logic macros.

2020-11-09T02:46:49+00:00

Match other use of ALWAYS_REALLOC.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14540

Signed-off-by: Jeremy Allison 
Reviewed-by: Andrew Bartlett

talloc: also use portable __has_attribute macro to check for "deprecated" attribute

2020-10-16T04:45:40+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14526

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett