samba.git/lib/tsocket, branch talloc-2.4.2

lib/tsocket: add tstream_bsd_fail_readv_first_error()

2023-10-24T09:36:37+00:00

This gives the caller the option to fail immediately if
TEVENT_FD_ERROR appear even with pending bytes in the
recv queue.

Servers typically want to activate this in order to avoid
pointless work, while clients typically want to read
pending responses from the recv queue.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett

lib/tsocket: make use of TEVENT_FD_ERROR in tstream_bsd_fde_handler()

2023-10-24T09:36:37+00:00

This makes the logic introduced to fix bug #15202 simpler.

While developing this I noticed that a lot of callers
rely on the fact that they can read the pending bytes out
of the recv queue before EOF is reported.

So I changed the code handle TEVENT_FD_ERROR together with
TEVENT_FD_READ in a way that keep the existing callers happy.

In the next step we'll add a way to let callers opt-in in order
to fail immediately if TEVENT_FD_ERROR appears (even if there
are pending bytes remaining in the recv queue).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15202

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett

lib/tsocket: let tstream_bsd_connect_send() use TEVENT_FD_ERROR instead of TEVENT_FD_READ

2023-10-24T09:36:37+00:00

This mostly cosmetic, but now that we have TEVENT_FD_ERROR we should use it.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett

lib/tsocket: make use of samba_socket_sock_error()

2023-10-24T09:36:37+00:00

This is nicer than calling getsockopt(state->fd, SOL_SOCKET, SO_ERROR)
directly.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett

lib/tsocket: make use of samba_socket_poll_or_sock_error()

2023-10-24T09:36:37+00:00

This is just a copy of the existing code...

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett

tsocket: Fix code spelling

2023-08-14T04:57:34+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:tsocket: Fix code spelling

2023-04-14T05:25:33+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Joseph Sutton

tsocket: Increase tcp_user_timeout max_loops

2023-03-14T06:16:30+00:00

Often, on rackspace GitLab CI runners, we get:

UNEXPECTED(failure): samba.unittests.tsocket_tstream.test_tstream_more_tcp_user_timeout_spin(none)
REASON: Exception: Exception: 0xf == 0xf
../../lib/tsocket/tests/test_tstream.c:405: error: Failure!

This allows us more spins before we fail the test.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15328
Signed-off-by: Andrew Bartlett 
Reviewed-by: Joseph Sutton

lib/tsocket: fix a typo in the tsocket guide doc

2023-01-17T18:23:18+00:00

Signed-off-by: Björn Baumbach 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Björn Baumbach 
Autobuild-Date(master): Tue Jan 17 18:23:18 UTC 2023 on sn-devel-184

tsocket: Fix the build on FreeBSD

2022-12-12T21:16:33+00:00

FreeBSD does not have TCP_USER_TIMEOUT

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison