samba.git/lib/util/debug.c, branch talloc-2.2.0

lib/debug: retain full string in state.prog_name global

2019-02-07T16:23:18+00:00

setup_logging() retains a global pointer to the provided const string in
state.prog_name, which is later used in the debug_backend->reload()
callback.
Some setup_logging() callers, such as popt_common_callback(),
incorrectly assume that a dynamic buffer is safe to provide as a
prog_name parameter. Fix this by copying the entire string in
setup_logging().

Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

debug: enable per debug-class logfiles

2018-12-20T02:19:27+00:00

This finally enables per debug-class logfiles by hooking into
reopen_logs_internal() calls to reopen_one_log() per configured
debug-class.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: remove fd and debugf from state, use dbgc_config[DBGC_ALL]

2018-12-20T02:19:27+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: update logsize checking for per debug-class logfiles

2018-12-20T02:19:27+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: update need_to_check_log_size() for per debug-class logfiles

2018-12-20T02:19:27+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: add support for per debug-class logfiles

2018-12-20T02:19:27+00:00

This adds support for per debug-class logfiles to the function parsing
the "log level" option.

The enhanced syntax is:

  log level = CLASS:LEVEL[@PATH] [CLASS:LEVEL[@PATH] ... ]

Eg

  log level = full_audit:1@/var/log/audit.logfile

While the option is already parsed and stored in in the dbgc_config[]
array, the feature is still effectively disabled, as
reopen_logs_internal() still doesn't open the per debug-class logfiles.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: add resource cleanup for per debug-class logfiles

2018-12-20T02:19:27+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: add logfile and fd to struct debug_class

2018-12-20T02:19:26+00:00

Initialized to -1. Already checked in debug_file_log() without affecting
behaviour until subsequent commits set per-debug-class fds.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: factor out logfile size check

2018-12-20T02:19:26+00:00

The new function will also be used for upcoming per-debug-class logfiles.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: factor out a function that opens and closes the new and old logfile

2018-12-20T02:19:26+00:00

The new function reopen_one_log() will also be used for per-class
logfiles in subsequent commmits.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison