samba.git/lib/util/debug.c, branch talloc-2.3.1

Spelling fixes s/preceeding/preceding/

2019-09-01T22:21:28+00:00

Signed-off-by: Mathieu Parent 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

lib/util: clang: Fix 'Null pointer passed as an argument...' warning

2019-06-11T12:10:17+00:00

Fixes:

lib/util/debug.c:705:7: warning: Null pointer passed as an argument to a 'nonnull' parameter <--[clang]

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer gary@catalyst.net.nz

lib/util: set current_msg_{level,class} also during a DEBUGADD[C]() call

2019-05-28T07:16:25+00:00

In some situations we use DEBUGADDC() in order to print out content
without a related debug header line.

This is important with the new per class logfile with:

 log level = 1 dsdb_json_audit:10@/var/log/samba/log.dsdb_json_audit

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13915

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib util debug: Increase format buffer to 4KiB

2019-05-06T01:18:21+00:00

Increase the debug line buffer to 4KiB, the existing size of 1KiB is too
small for dsdbChange JSON audit messages.  These messages were then
split across multipe lines causing issues in log ingestion tools
expecting single line messages.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13902

Signed-off-by: Gary Lockyer 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Gary Lockyer 
Autobuild-Date(master): Mon May  6 01:18:22 UTC 2019 on sn-devel-184

lib/debug: retain full string in state.prog_name global

2019-02-07T16:23:18+00:00

setup_logging() retains a global pointer to the provided const string in
state.prog_name, which is later used in the debug_backend->reload()
callback.
Some setup_logging() callers, such as popt_common_callback(),
incorrectly assume that a dynamic buffer is safe to provide as a
prog_name parameter. Fix this by copying the entire string in
setup_logging().

Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

debug: enable per debug-class logfiles

2018-12-20T02:19:27+00:00

This finally enables per debug-class logfiles by hooking into
reopen_logs_internal() calls to reopen_one_log() per configured
debug-class.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: remove fd and debugf from state, use dbgc_config[DBGC_ALL]

2018-12-20T02:19:27+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: update logsize checking for per debug-class logfiles

2018-12-20T02:19:27+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: update need_to_check_log_size() for per debug-class logfiles

2018-12-20T02:19:27+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

debug: add support for per debug-class logfiles

2018-12-20T02:19:27+00:00

This adds support for per debug-class logfiles to the function parsing
the "log level" option.

The enhanced syntax is:

  log level = CLASS:LEVEL[@PATH] [CLASS:LEVEL[@PATH] ... ]

Eg

  log level = full_audit:1@/var/log/audit.logfile

While the option is already parsed and stored in in the dbgc_config[]
array, the feature is still effectively disabled, as
reopen_logs_internal() still doesn't open the per debug-class logfiles.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison