samba.git/lib/util/debug.c, branch talloc-2.3.2

debug: remove a cast, which makes the Solaris Studio compiler unhappy

2020-11-10T06:53:42+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14526

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

lib/debug: set the correct default backend loglevel to MAX_DEBUG_LEVEL

2020-07-02T13:25:29+00:00

This fixed a regression introduced by commit
c83ce5f4f99aef94530411ec82cc03e9935b352d for bug #14345.

The backend loglevel globally restricts logging of a particular backend. If this
value is smaller then any explicitly configured logging class, logging for this
class is skipped.

Eg, given the following logging config in smb.conf:

  log level = 1 auth_json_audit:3@/var/log/samba/samba_auth_audit.log

the default class loglevel of 1 (dbgc_config[DBGC_ALL].loglevel) will be
assigned to the backend loglevel.

So even though the logging class auth_json_audit is configured at level 3, this
doesn't become effective as the file backend drops all log messages with a level
below 1.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14426

Signed-off-by: Ralph Boehme 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Thu Jul  2 13:25:29 UTC 2020 on sn-devel-184

lib/debug: assert file backend

2020-07-02T12:03:33+00:00

The debug file backend is a built-in default, if it's missing we're totally
screwed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14426

Signed-off-by: Ralph Boehme 
Reviewed-by: Andreas Schneider

lib:util: Fix smbclient -l basename dir

2020-05-07T10:38:29+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14345

Pair-Programmed-With: Andreas Schneider 
Signed-off-by: Andreas Schneider 
Signed-off-by: Amit Kumar 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Thu May  7 10:38:29 UTC 2020 on sn-devel-184

util: Fix signed/unsigned integer comparison

2020-04-22T01:48:02+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Wed Apr 22 01:48:03 UTC 2020 on sn-devel-184

lib: Fix rotating nonstandard debug class log files

2020-02-19T09:38:39+00:00

Looking at the same pointer in the loop does not really make sense to
me

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

Spelling fixes s/preceeding/preceding/

2019-09-01T22:21:28+00:00

Signed-off-by: Mathieu Parent 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

lib/util: clang: Fix 'Null pointer passed as an argument...' warning

2019-06-11T12:10:17+00:00

Fixes:

lib/util/debug.c:705:7: warning: Null pointer passed as an argument to a 'nonnull' parameter <--[clang]

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer gary@catalyst.net.nz

lib/util: set current_msg_{level,class} also during a DEBUGADD[C]() call

2019-05-28T07:16:25+00:00

In some situations we use DEBUGADDC() in order to print out content
without a related debug header line.

This is important with the new per class logfile with:

 log level = 1 dsdb_json_audit:10@/var/log/samba/log.dsdb_json_audit

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13915

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib util debug: Increase format buffer to 4KiB

2019-05-06T01:18:21+00:00

Increase the debug line buffer to 4KiB, the existing size of 1KiB is too
small for dsdbChange JSON audit messages.  These messages were then
split across multipe lines causing issues in log ingestion tools
expecting single line messages.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13902

Signed-off-by: Gary Lockyer 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Gary Lockyer 
Autobuild-Date(master): Mon May  6 01:18:22 UTC 2019 on sn-devel-184