samba.git/lib/util/dlinklist.h, branch talloc-2.3.3

DLIST_REMOVE: clang: Fix dereference of a null pointer warning

2019-06-11T12:10:17+00:00

Fixes:

lib/tevent/tevent_wrapper.c:295:3: warning: Access to field 'next' results in a dereference of a null pointer (loaded from field 'prev') <--[clang]

Additionally fix similar instance of the same macro

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer gary@catalyst.net.nz

Revert "lib:dlinklist: avoid -Wtautological-compare errors with gcc6"

2016-07-14T22:54:12+00:00

This reverts commit 5d85fd85467eb1f8941641d5f71d75e7d5c7234c.

Breaks compile for older (<= 4.4) gccs.
Needs to be done differently.

Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison

lib:dlinklist: avoid -Wtautological-compare errors with gcc6

2016-07-14T00:06:10+00:00

We expect these macros to generate tautological compares
intentionally, so disabling the warning is just fine.

This lets --picky-developer work with gcc6 and newer.

Pair-Programmed-With: Michael Adam 

Signed-off-by: Michael Adam 
Signed-off-by: Ira Cooper 
Reviewed-by: Jeremy Allison

dlist: remove outdated comment about type argument

2016-02-06T20:48:18+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison

dlist: remove unneeded type argument from DLIST_CONCATENATE()

2016-02-06T20:48:18+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison

dlist: remove unneeded argument from DLIST_DEMOTE()

2016-02-06T20:48:17+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison

dlist: remove unneeded type argument from DLIST_ADD_END()

2016-02-06T20:48:17+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison

dlinklist: Fix a typo

2014-04-02T15:11:37+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Michael Adam 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Wed Apr  2 17:11:37 CEST 2014 on sn-devel-104

util: rewrite dlinklist.h so that DLIST_ADD_END() is O(1)

2010-02-10T23:53:58+00:00

This changes the meaning of the ->prev pointer in our doubly linked
lists to point at the end of the list from the front of the list. That
allows us to implement DLIST_ADD_END() and related functions in O(1)
time, which can be a huge saving in many places in Samba.

This also means that the 'type' argument to various DLIST_*() macros
is no longer needed, but I have left it in for now to keep the
patchset small, which will make it easier to revert if any problems
are found. In the future we should remove the 'type' arguments.

(jra. Move the one use of DLIST_TAIL over to the new macros).

Temporary changes to dlinklist to keep the implementation static whilst

2010-02-10T23:30:59+00:00

uses of (list)->prev are moved over to DLIST_PREV. This will be replaced
when the final (new) version of the dlinklist.h header is added.

Jeremy.