samba.git/lib/util/substitute.c, branch talloc-2.3.4

util:str_sub: talloc_free on error

2021-03-11T21:42:43+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jeremy Allison

lib/util: Replace buggy string_sub_talloc() with talloc_string_sub() in lib/util

2021-03-10T08:06:25+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14658

Signed-off-by: Andrew Bartlett 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Wed Mar 10 08:06:25 UTC 2021 on sn-devel-184

util: Fix off-by-one error in message about overflow

2019-07-05T02:24:52+00:00

len includes space for the NUL character, so the calculation needs to
take the NUL character into account.

While touching this, drop unnecessary casts by updating format string
and update to modern debug macro.

Signed-off-by: Martin Schwenke 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri Jul  5 02:24:52 UTC 2019 on sn-devel-184

util: Avoid localised underflow

2019-07-05T01:05:21+00:00

Avoid parenthesising an unsigned subtraction that can be negative and,
therefore, underflow.  There is no need for the parentheses and
removing them results in an expression that is evaluated left-to-right
and can not underflow.

It isn't clear that the underflow matters.  lp <= ls, so if (li - lp)
underflows then ls + (li - lp) will always overflow.  This should
produce the correct answer.  However, depending on this seems wrong.

Signed-off-by: Martin Schwenke 
Reviewed-by: Andrew Bartlett

util: Fix signed/unsigned comparisons by declaring as size_t

2019-07-01T06:44:13+00:00

I may be missing something subtle but I can't see a reason for
declaring these as ssize_t.

Signed-off-by: Martin Schwenke 
Reviewed-by: Andreas Schneider

lib:util: Add FALL_THROUGH statements in substitute.c

2018-03-01T03:37:41+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

lib/util: Use charset_compat.h if SAMBA_UTIL_CORE_ONLY

2014-10-03T22:11:21+00:00

When doing a CTDB standalone build we don't want to use dynconfig,
since this introduces a lot of unwanted complexity.  To avoid this,
either:

* charset needs to be nobbled to avoid loading the case tables, since
  this depends on dynconfig; or

* charset needs to be avoid completely, so some functions need to be
  replaced with their ASCII counterparts.

The 2nd options seems more honest and less error-prone.

Signed-off-by: Martin Schwenke 
Reviewed-by: Jeremy Allison

lib/util: Clean up includes for substitute.c

2014-10-03T22:11:21+00:00

Add substitute.h.  Allows standalone compiles without external
includes.h.

Signed-off-by: Martin Schwenke 
Reviewed-by: Jeremy Allison

lib/util: Replace an SMB_ASSERT()

2014-10-03T22:11:21+00:00

Avoid a cyclic dependency.

Signed-off-by: Martin Schwenke 
Reviewed-by: Jeremy Allison

lib/util Re-merge the string_sub() and all_string_sub() from source3

2011-04-29T06:38:15+00:00

Andrew Bartlett