<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/lib/util/tests/file.c, branch talloc-2.3.4</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>s4-torture: test file_line_parse as well</title>
<updated>2020-11-13T17:47:33+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gd@samba.org</email>
</author>
<published>2020-11-10T16:10:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=a8ec83049176fdebe086be8c03c7d058c58f48d8'/>
<id>a8ec83049176fdebe086be8c03c7d058c58f48d8</id>
<content type='text'>
Guenther

Signed-off-by: Guenther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Günther Deschner &lt;gd@samba.org&gt;
Autobuild-Date(master): Fri Nov 13 17:47:33 UTC 2020 on sn-devel-184
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Guenther

Signed-off-by: Guenther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Günther Deschner &lt;gd@samba.org&gt;
Autobuild-Date(master): Fri Nov 13 17:47:33 UTC 2020 on sn-devel-184
</pre>
</div>
</content>
</entry>
<entry>
<title>lib/util/tests: clang fix Value stored to 'lines' is never read warning</title>
<updated>2019-06-04T22:13:07+00:00</updated>
<author>
<name>Noel Power</name>
<email>noel.power@suse.com</email>
</author>
<published>2019-05-23T13:52:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=a0ccec6291a219ded9b1a86ddaa18a61456699da'/>
<id>a0ccec6291a219ded9b1a86ddaa18a61456699da</id>
<content type='text'>
Fixes

lib/util/tests/file.c:153:2: warning: Value stored to 'lines' is never read &lt;--[clang]

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Andreas Schneider &lt;asn@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes

lib/util/tests/file.c:153:2: warning: Value stored to 'lines' is never read &lt;--[clang]

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Andreas Schneider &lt;asn@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib/util: Count a trailing line that doesn't end in a newline</title>
<updated>2018-12-19T07:08:28+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>martin@meltin.net</email>
</author>
<published>2018-12-14T03:43:57+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=5118985841aa0363147d552f243ab5a7d90dbdaf'/>
<id>5118985841aa0363147d552f243ab5a7d90dbdaf</id>
<content type='text'>
If the final line of a file does not contain a newline then it isn't
included in the line count.

Change i to point to the next slot in the array instead of the current
one.  This means that that the current line won't be thrown away if no
newline is seen.

Without changing i to unsigned int, the -O3 --picky -developer build
fails with:

[ 745/4136] Compiling lib/util/util_file.c

==&gt; /builds/samba-team/devel/samba/samba-o3.stderr &lt;==
../../lib/util/util_file.c: In function ‘file_lines_parse’:
../../lib/util/util_file.c:251:8: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
  while (i &gt; 0 &amp;&amp; ret[i-1][0] == 0) {
        ^
cc1: all warnings being treated as errors

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13717

Signed-off-by: Martin Schwenke &lt;martin@meltin.net&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;

Autobuild-User(master): Andrew Bartlett &lt;abartlet@samba.org&gt;
Autobuild-Date(master): Wed Dec 19 08:08:28 CET 2018 on sn-devel-144
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If the final line of a file does not contain a newline then it isn't
included in the line count.

Change i to point to the next slot in the array instead of the current
one.  This means that that the current line won't be thrown away if no
newline is seen.

Without changing i to unsigned int, the -O3 --picky -developer build
fails with:

[ 745/4136] Compiling lib/util/util_file.c

==&gt; /builds/samba-team/devel/samba/samba-o3.stderr &lt;==
../../lib/util/util_file.c: In function ‘file_lines_parse’:
../../lib/util/util_file.c:251:8: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
  while (i &gt; 0 &amp;&amp; ret[i-1][0] == 0) {
        ^
cc1: all warnings being treated as errors

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13717

Signed-off-by: Martin Schwenke &lt;martin@meltin.net&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;

Autobuild-User(master): Andrew Bartlett &lt;abartlet@samba.org&gt;
Autobuild-Date(master): Wed Dec 19 08:08:28 CET 2018 on sn-devel-144
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: Fix a few CIDs for Resource Leak</title>
<updated>2015-04-21T17:37:16+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2015-03-31T07:34:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=0f91e4e18db5f896c94f98e84f572568d0b1c3e4'/>
<id>0f91e4e18db5f896c94f98e84f572568d0b1c3e4</id>
<content type='text'>
Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Michael Adam &lt;obnox@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Michael Adam &lt;obnox@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib/util/tests: add missing #include "torture/local/proto.h"</title>
<updated>2014-04-02T07:03:44+00:00</updated>
<author>
<name>Stefan Metzmacher</name>
<email>metze@samba.org</email>
</author>
<published>2014-02-27T08:08:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=8ba775b0a3e22a83bca092114dbb9f345d6ff89f'/>
<id>8ba775b0a3e22a83bca092114dbb9f345d6ff89f</id>
<content type='text'>
Signed-off-by: Stefan Metzmacher &lt;metze@samba.org&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Stefan Metzmacher &lt;metze@samba.org&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s4-smbtorture: Make test names lowercase and dot-separated.</title>
<updated>2010-12-11T03:16:13+00:00</updated>
<author>
<name>Jelmer Vernooij</name>
<email>jelmer@samba.org</email>
</author>
<published>2010-12-11T02:26:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=35fbc7bbda5851f7172538f79fc79be201f1d521'/>
<id>35fbc7bbda5851f7172538f79fc79be201f1d521</id>
<content type='text'>
This is consistent with the test names used by selftest, should
make the names less confusing and easier to integrate with other tools.

Autobuild-User: Jelmer Vernooij &lt;jelmer@samba.org&gt;
Autobuild-Date: Sat Dec 11 04:16:13 CET 2010 on sn-devel-104
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is consistent with the test names used by selftest, should
make the names less confusing and easier to integrate with other tools.

Autobuild-User: Jelmer Vernooij &lt;jelmer@samba.org&gt;
Autobuild-Date: Sat Dec 11 04:16:13 CET 2010 on sn-devel-104
</pre>
</div>
</content>
</entry>
<entry>
<title>Test maxsize parameter to file_load() as used in Samba 3.</title>
<updated>2008-10-13T14:40:27+00:00</updated>
<author>
<name>Jelmer Vernooij</name>
<email>jelmer@samba.org</email>
</author>
<published>2008-10-13T14:40:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=65d5b1e7b494f94cf1ffef04ab74a68967789d89'/>
<id>65d5b1e7b494f94cf1ffef04ab74a68967789d89</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix number of arguments for file_load() functions.</title>
<updated>2008-10-12T17:46:38+00:00</updated>
<author>
<name>Jelmer Vernooij</name>
<email>jelmer@samba.org</email>
</author>
<published>2008-10-12T17:46:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=3994c42f1938e35218cd5708fcc5a22b1b9a761d'/>
<id>3994c42f1938e35218cd5708fcc5a22b1b9a761d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move lib/util from source4 to top-level libutil.</title>
<updated>2008-10-11T19:05:38+00:00</updated>
<author>
<name>Jelmer Vernooij</name>
<email>jelmer@samba.org</email>
</author>
<published>2008-10-11T19:05:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=caa4e428604780bb098060f7286c69d30c8b4007'/>
<id>caa4e428604780bb098060f7286c69d30c8b4007</id>
<content type='text'>
Conflicts:

	source4/Makefile
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Conflicts:

	source4/Makefile
</pre>
</div>
</content>
</entry>
</feed>
