samba.git/lib/util/tests/util.c, branch talloc-2.4.0

lib/util: Add test of mem_equal_const_time()

2022-06-09T22:49:29+00:00

Ensure that it gives the correct results for comparing two memory
regions.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib: relicense smb_strtoul(l) under LGPLv3

2020-08-03T22:21:02+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Swen Schillig 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Mon Aug  3 22:21:04 UTC 2020 on sn-devel-184

tests-util: Adding test to verify "allow no conversion" flag

2019-06-30T12:47:24+00:00

The internal string conversion routines smb_strtoul(l) return
an error if the provided string could not be converted to an integer.
This can be the case if the string is empty or if it starts with non-numeric
characters which cannot be converted.
The standard C library, however, does allow this and simply returns 0 as the
converted value.
If this behaviour is wanted, it can be enabled by using
the "SMB_STR_ALLOW_NO_CONVERSION" flag.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Sun Jun 30 12:47:24 UTC 2019 on sn-devel-184

tests-util: Adding test to verify "full-string-conversion" flag

2019-06-30T11:32:19+00:00

The standard string to integer conversion routines stop at the first
character which cannot be converted to a number.
However, if such a character is found, it is not considered an error.
With the flag "SMB_STR_FULL_STR_CONV" enabled, an error will be returned
if the string could not be converted entirely.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

tests-util: Adding test to verify "allow-negative" flag

2019-06-30T11:32:18+00:00

The standard string to integer conversion routines allow strings
with a leading "-" to indicate a negative number.
However, the returned value is always an unsigned value representing
the bit-pattern of this negative value.
Typically, this behaviour is NOT wanted and therefore the standard
behavior of the internal smb_strtoul(l) return an erros in such situations.
It can be enabled though by using the flag SMB_STR_ALLOW_NEGATIVE.
This test verifies the correct processing.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

lib: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30T11:32:18+00:00

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

tests-util: Adding test to verify "no-conversion" detection

2019-06-30T11:32:18+00:00

The standard string to integer conversion routines return zero
if a string was to be converted which did not reflect a number.
It is not flag'ed as an error.
The wrapper functions strtoul_err() and strtoull_err() are expected
to exactly do this.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

tests-util: Adding test to verify negative "number" detection

2019-06-30T11:32:17+00:00

Verify that a string representing a negative number is throwing an error.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

tests-util: Adding strtoul(l)_err() test leaving errno untouched

2019-06-30T11:32:17+00:00

The wrapper functions strtoul_err() and strtoull_err() trigger
other functions/routines which modify errno.
However, callers of those wrapper functions expect errno to be unchanged.
This test verifies the expectation.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

torture: Remove unnecesssary #include

2018-09-15T13:18:25+00:00

This is now provided through system/filesys.h.

Signed-off-by: Christof Schmitt 
Reviewed-by: Andrew Bartlett