samba.git/lib/util/tests, branch talloc-2.3.0

tests-util: Adding test to verify "allow no conversion" flag

2019-06-30T12:47:24+00:00

The internal string conversion routines smb_strtoul(l) return
an error if the provided string could not be converted to an integer.
This can be the case if the string is empty or if it starts with non-numeric
characters which cannot be converted.
The standard C library, however, does allow this and simply returns 0 as the
converted value.
If this behaviour is wanted, it can be enabled by using
the "SMB_STR_ALLOW_NO_CONVERSION" flag.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Sun Jun 30 12:47:24 UTC 2019 on sn-devel-184

tests-util: Adding test to verify "full-string-conversion" flag

2019-06-30T11:32:19+00:00

The standard string to integer conversion routines stop at the first
character which cannot be converted to a number.
However, if such a character is found, it is not considered an error.
With the flag "SMB_STR_FULL_STR_CONV" enabled, an error will be returned
if the string could not be converted entirely.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

tests-util: Adding test to verify "allow-negative" flag

2019-06-30T11:32:18+00:00

The standard string to integer conversion routines allow strings
with a leading "-" to indicate a negative number.
However, the returned value is always an unsigned value representing
the bit-pattern of this negative value.
Typically, this behaviour is NOT wanted and therefore the standard
behavior of the internal smb_strtoul(l) return an erros in such situations.
It can be enabled though by using the flag SMB_STR_ALLOW_NEGATIVE.
This test verifies the correct processing.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

lib: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30T11:32:18+00:00

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

tests-util: Adding test to verify "no-conversion" detection

2019-06-30T11:32:18+00:00

The standard string to integer conversion routines return zero
if a string was to be converted which did not reflect a number.
It is not flag'ed as an error.
The wrapper functions strtoul_err() and strtoull_err() are expected
to exactly do this.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

tests-util: Adding test to verify negative "number" detection

2019-06-30T11:32:17+00:00

Verify that a string representing a negative number is throwing an error.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

tests-util: Adding strtoul(l)_err() test leaving errno untouched

2019-06-30T11:32:17+00:00

The wrapper functions strtoul_err() and strtoull_err() trigger
other functions/routines which modify errno.
However, callers of those wrapper functions expect errno to be unchanged.
This test verifies the expectation.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

lib/util/tests: clang fix Value stored to 'lines' is never read warning

2019-06-04T22:13:07+00:00

Fixes

lib/util/tests/file.c:153:2: warning: Value stored to 'lines' is never read <--[clang]

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

Fix uClibc build on 64bit platforms by including stdint.h

2019-05-19T17:34:20+00:00

Fixes an error detected by buildroot autobuilders:
http://autobuild.buildroot.net/results/573/573e2268e205e10d1352fa81122d8f225fdb4575/build-end.log

/home/rclinux/rc-buildroot-test/scripts/instance-1/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27:
error: conflicting types for 'uintptr_t'
 typedef unsigned long int uintptr_t;
                           ^
In file included from ../lib/ldb/tests/ldb_msg.c:17:0:
../third_party/cmocka/cmocka.h:126:28: note: previous declaration of 'uintptr_t' was here
       typedef unsigned int uintptr_t;

The define __WORDSIZE is missing when cmocka.h decides how to
define uintptr_t, this patch includes stdint.h when needed.

Patch sent upstream:
https://lists.samba.org/archive/samba-technical/2018-January/125306.html

[updated for samba-4.8.4, v2 sent upstream
 https://lists.samba.org/archive/samba-technical/2018-August/129732.html,
 updated for samba-4.9.1]

Signed-off-by: Bernd Kuhls 
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/samba4/0003-Fix-uClibc-build-on-64bit-platforms-by-including-std.patch]
Signed-off-by: Fabrice Fontaine 
Reviewed-by: Ralph Böhme 
Reviewed-by: Jeremy Allison

lib:util: Add a test for byteorder.h

2019-05-17T20:44:36+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri May 17 20:44:36 UTC 2019 on sn-devel-184