samba.git/lib/util/util_file.c, branch talloc-2.3.0

lib: Optimize file_compare

2019-07-17T12:45:51+00:00

Triggered by two coverity false positives. Loading both files into
talloc'ed memory seems inefficient to me. Rely on stdio to do proper
buffering. This removes the restriction from ae95d611: "It is meant for
small files".

This is more lines, but to me it has less implicit complexity.

Signed-off-by: Volker Lendecke 
Reviewed-by: Uri Simchoni 

Autobuild-User(master): Uri Simchoni 
Autobuild-Date(master): Wed Jul 17 12:45:51 UTC 2019 on sn-devel-184

util: Fix signed/unsigned comparisons by casting

2019-07-01T08:00:29+00:00

One case needs a variable declared, so it can be compared to -1 and
then cast to size_t for comparison.

Signed-off-by: Martin Schwenke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Mon Jul  1 08:00:29 UTC 2019 on sn-devel-184

util: Fix signed/unsigned comparisons by declaring as size_t

2019-07-01T06:44:13+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Andreas Schneider

lib: util: Remove file_pload()

2019-05-24T19:00:05+00:00

No longer used.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

lib: util: Add file_ploadv().

2019-05-24T19:00:05+00:00

Not yet used.

Duplicate code to file_pload() except uses vectored
argument list. file_pload() will be removed once all
callers are converted.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

lib: Make fd_load work for non-regular files

2019-03-26T04:43:40+00:00

Follow-up to

https://lists.samba.org/archive/samba/2018-September/217992.html

and following. This also fixes a small and very theoretical race: Between the
fstat and the read call the file size might change. This would make us fail on
potentially legitimate files.

This is more complex and probably slower, but looking at the use cases I don't
think the speed matters.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13859

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Mar 26 04:43:40 UTC 2019 on sn-devel-144

s3:util: Move static file_pload() function to lib/util

2019-02-11T06:43:31+00:00

file_pload() is static private function in Samba3 library, however it
does not have any special dependencies and might be widely used as
common function, so moving it into common samba-util library.

Signed-off-by: Aliaksei Karaliou 
Reviewed-by: Garming Sam 
Reviewed-by: Andrew Bartlett

lib/util: Count a trailing line that doesn't end in a newline

2018-12-19T07:08:28+00:00

If the final line of a file does not contain a newline then it isn't
included in the line count.

Change i to point to the next slot in the array instead of the current
one.  This means that that the current line won't be thrown away if no
newline is seen.

Without changing i to unsigned int, the -O3 --picky -developer build
fails with:

[ 745/4136] Compiling lib/util/util_file.c

==> /builds/samba-team/devel/samba/samba-o3.stderr <==
../../lib/util/util_file.c: In function ‘file_lines_parse’:
../../lib/util/util_file.c:251:8: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
  while (i > 0 && ret[i-1][0] == 0) {
        ^
cc1: all warnings being treated as errors

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13717

Signed-off-by: Martin Schwenke 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Dec 19 08:08:28 CET 2018 on sn-devel-144

lib:util: Fix size types in fgets_slash()

2018-04-03T18:20:10+00:00

This fixes compilation with -Wstrict-overflow=2.

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

lib:util: Add FALL_THROUGH statements in util_file.c

2018-03-01T03:37:41+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett