samba.git/lib/util/util_runcmd.c, branch master

lib: tevent_req_set_endtime() can fail

2025-09-02T08:08:28+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

lib: Fix the build on FreeBSD

2021-01-25T09:48:09+00:00

Commit 7d0981f5e78bc881ca6521932379c69604c33a38 broke the build on
FreeBSD:

[1589/3917] Compiling lib/util/util_runcmd.c
../../lib/util/util_runcmd.c:310:7: warning: implicit declaration of function 'WIFEXITED' is invalid in C99 [-Wimplicit-function-declaration]
                if (WIFEXITED(status)) {
                    ^
../../lib/util/util_runcmd.c:311:13: warning: implicit declaration of function 'WEXITSTATUS' is invalid in C99 [-Wimplicit-function-declaration]
                        status = WEXITSTATUS(status);
                                 ^
../../lib/util/util_runcmd.c:312:14: warning: implicit declaration of function 'WIFSIGNALED' is invalid in C99 [-Wimplicit-function-declaration]
                } else if (WIFSIGNALED(status)) {
                           ^
../../lib/util/util_runcmd.c:313:13: warning: implicit declaration of function 'WTERMSIG' is invalid in C99 [-Wimplicit-function-declaration]
                        status = WTERMSIG(status);
                                 ^
4 warnings generated.

[1590/3917] Linking bin/default/source4/dsdb/libsamdb-common-samba4.so
ld: error: undefined symbol: WIFEXITED
>>> referenced by util_runcmd.c
>>>               lib/util/util_runcmd.c.94.o:(samba_runcmd_io_handler)

ld: error: undefined symbol: WEXITSTATUS
>>> referenced by util_runcmd.c
>>>               lib/util/util_runcmd.c.94.o:(samba_runcmd_io_handler)

ld: error: undefined symbol: WIFSIGNALED
>>> referenced by util_runcmd.c
>>>               lib/util/util_runcmd.c.94.o:(samba_runcmd_io_handler)

ld: error: undefined symbol: WTERMSIG
>>> referenced by util_runcmd.c
>>>               lib/util/util_runcmd.c.94.o:(samba_runcmd_io_handler)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Mon Jan 25 09:48:09 UTC 2021 on sn-devel-184

lib: Avoid an "includes.h"

2021-01-22T19:54:37+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib/util: inline lib/util/util_runcmd.h again

2019-02-08T01:54:20+00:00

samba_runcmd_state should not be exposed!

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri Feb  8 02:54:20 CET 2019 on sn-devel-144

lib/util: add samba_runcmd_export_stdin() helper function

2019-02-07T21:47:22+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

lib/util/run_cmd: use a cleanup function instead of a destructor

2017-09-30T10:14:56+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13062

Pair-programmed-with: Stefan Metzmacher 

Signed-off-by: Stefan Metzmacher 
Signed-off-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Sat Sep 30 12:14:57 CEST 2017 on sn-devel-144

lib/util/run_cmd: remove a printf

2017-09-30T06:01:25+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13062

Pair-programmed-with: Stefan Metzmacher 

Signed-off-by: Stefan Metzmacher 
Signed-off-by: Ralph Boehme

lib/util/run_cmd: ensure fd_stdin gets set to -1 in the destructor

2017-09-30T06:01:24+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13062

Pair-programmed-with: Stefan Metzmacher 

Signed-off-by: Stefan Metzmacher 
Signed-off-by: Ralph Boehme

lib/util/run_cmd: prevent zombies in samba_runcmd_send on timeout

2017-09-30T06:01:24+00:00

Ensure the state desctructor calls tfork_destroy to reap the waiter and
worker processes. Otherwise we leave the waiter process as a zombie
behind us as we never call waitpid on it in case of a timeout
or talloc_free() from the caller.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13062

Pair-programmed-with: Stefan Metzmacher 

Signed-off-by: Stefan Metzmacher 
Signed-off-by: Ralph Boehme

util_runcmd: Free the fde in event handler.

2017-09-16T21:50:27+00:00

Free the fde in the event handler to prevent the event triggering again
While not strictly necessary in this case, this code serves as an
example of the usage of tfork.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13037

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Sat Sep 16 23:50:27 CEST 2017 on sn-devel-144