samba.git/lib/util, branch talloc-2.3.0

s3:utils: New struct to fix strict aliasing issues with sockets API

2019-07-22T16:49:14+00:00

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andreas Schneider

lib:util: Use GnuTLS random number generator in genrand.c

2019-07-18T01:30:20+00:00

FIPS requires that a random number generator from a certified crypto
library is used.

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Jul 18 01:30:20 UTC 2019 on sn-devel-184

lib: Optimize file_compare

2019-07-17T12:45:51+00:00

Triggered by two coverity false positives. Loading both files into
talloc'ed memory seems inefficient to me. Rely on stdio to do proper
buffering. This removes the restriction from ae95d611: "It is meant for
small files".

This is more lines, but to me it has less implicit complexity.

Signed-off-by: Volker Lendecke 
Reviewed-by: Uri Simchoni 

Autobuild-User(master): Uri Simchoni 
Autobuild-Date(master): Wed Jul 17 12:45:51 UTC 2019 on sn-devel-184

lib/util: clang: Fix 'Null pointer passed as an argument'

2019-07-08T09:30:09+00:00

Fixes lib/util/iov_buf.c:50:4: warning: Null pointer passed as an argument to a 'nonnull' parameter <--[clang]
                        memcpy(p, iov[i].iov_base, thislen);
                        ^
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

util: Fix off-by-one error in message about overflow

2019-07-05T02:24:52+00:00

len includes space for the NUL character, so the calculation needs to
take the NUL character into account.

While touching this, drop unnecessary casts by updating format string
and update to modern debug macro.

Signed-off-by: Martin Schwenke 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri Jul  5 02:24:52 UTC 2019 on sn-devel-184

util: Avoid localised underflow

2019-07-05T01:05:21+00:00

Avoid parenthesising an unsigned subtraction that can be negative and,
therefore, underflow.  There is no need for the parentheses and
removing them results in an expression that is evaluated left-to-right
and can not underflow.

It isn't clear that the underflow matters.  lp <= ls, so if (li - lp)
underflows then ls + (li - lp) will always overflow.  This should
produce the correct answer.  However, depending on this seems wrong.

Signed-off-by: Martin Schwenke 
Reviewed-by: Andrew Bartlett

lib: Fix return of server_id_db_prune_name()

2019-07-03T10:51:32+00:00

The tdb routines return 0/-1 and return the specific error via
tdb_error(). server_id_db_prune_name() is expected to return an errno,
not 0/-1.

Signed-off-by: Volker Lendecke 
Reviewed-by: Noel Power 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Wed Jul  3 10:51:32 UTC 2019 on sn-devel-184

lib/util: clang: Fix warning: Value stored to 'ret' is never read warning

2019-07-01T13:34:11+00:00

Fixes:

lib/util/server_id_db.c:181:3: warning: Value stored to 'ret' is never read <--[clang]
                ret = tdb_store(tdb, key, talloc_tdb_data(ids), TDB_MODIFY);
                ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

lib/util: Fix Value stored to 'ret' is never read warning

2019-07-01T13:34:10+00:00

Fixes:

lib/util/tfork.c:260:3: warning: Value stored to 'ret' is never read <--[clang]

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

util: Fix signed/unsigned comparisons by casting

2019-07-01T08:00:29+00:00

One case needs a variable declared, so it can be compared to -1 and
then cast to size_t for comparison.

Signed-off-by: Martin Schwenke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Mon Jul  1 08:00:29 UTC 2019 on sn-devel-184