samba.git/lib/util, branch talloc-2.3.2

util_net: fix a statement not reached warning

2020-11-10T06:53:43+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

debug: remove a cast, which makes the Solaris Studio compiler unhappy

2020-11-10T06:53:42+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14526

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

lib: Remove an optimization in string_replace()

2020-09-30T15:58:38+00:00

Why? This simplifies the code.

Why do I believe we can do this? I don't think this is a very common
operation in critical code paths. Also, next_codepoint() already has
the same optimization. If this turns out to be a measurable
performance issue, we should turn next_codepoint() into a static
inline function doing the 7-bit optimized code path inlined the same
way we did it for tdb_oob(). This way all callers would benefit from
this optimization.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

utils/asn1: avoid undefined behaviour warning

2020-09-11T05:05:59+00:00

UBSAN does not like an int >= 1<<24 being shifted left.
We check the overflow in the very next line.

Credit to OSS-Fuzz.

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25436

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri Sep 11 05:05:59 UTC 2020 on sn-devel-184

lib/util/asn1: avoid technically undefined shift

2020-08-31T21:06:29+00:00

UBSAN says

 runtime error: left shift of 255 by 24 places cannot be represented in type 'int'

Credit to OSS-Fuzz.

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22889

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer

lib/util: remove extra safe_string.h file

2020-08-28T02:18:40+00:00

lib/util/safe_string.h is similar to source3/include/safe_string.h, but
the former has fewer checks. It is missing bcopy, strcasecmp, and
strncasecmp.

Add the missing elements to lib/util/safe_string.h remove the other
safe_string.h which is in the source3-specific path. To accomodate
existing uses of str(n?)casecmp, add #undef lines to source files where
they are used.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Aug 28 02:18:40 UTC 2020 on sn-devel-184

string_wrappers: include replace.h

2020-08-28T00:56:34+00:00

To ensure we always get the right value for the config.h macro
`HAVE_COMPILER_WILL_OPTIMIZE_OUT_FNS`, #include "lib/util/replace.h"
rather than rely on it being included by the API user.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison

lib/util: do not make string_wrappers.h public

2020-08-28T00:56:34+00:00

string_wrappers.h is a collection of macros. All but one of the macros
rely on symbols not defined in public headers, so it is not useful as a
public header.

For instance, fstring is defined in includes.h. PTR_DIFF is defined in
lib/util/memory.h, which is not public.

checked_strlcpy is actually self-contained and is usable outside of a
Samba build, but without a Samba config.h, it is just aliased to
strlcpy.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison

lib/util: Move cleanup for unit test in teardown function

2020-08-24T03:10:09+00:00

Where to call rmdir does not matter, but that should avoid the TOCTOU
warning from CID 1466194 and might be slightly cleaner.

Signed-off-by: Christof Schmitt 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Aug 24 03:10:09 UTC 2020 on sn-devel-184

lib/util: Remove wrong return statement in unit test

2020-08-24T01:46:30+00:00

Fixes CID 1466195

Signed-off-by: Christof Schmitt 
Reviewed-by: Andrew Bartlett