samba.git/lib/util, branch talloc-2.4.0

lib/tfork: Don't overwrite 'ret' in cleanup phase

2023-01-10T20:22:32+00:00

The cleanup phase of tfork_create() saves errno prior to calling
functions that might modify it, with the intention of restoring it
afterwards. However, the value of 'ret' is accidentally overwritten. It
will always be equal to 0, and hence errno will not be restored.

Fix this by introducing a new variable, ret2, for calling functions in
the cleanup phase.

Signed-off-by: Joseph Sutton 
Reviewed-by: Jeremy Allison

lib: Remove idtree from samba_util.h

2023-01-10T00:28:37+00:00

No need to recompile the world when only a few files need this.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Add "starting_id" to idr_get_new_random()

2023-01-10T00:28:37+00:00

To be used in smbXsrv_open.c, for this we need a lower bound.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Use talloc_asprintf_addbuf() in print_socket_options()

2022-12-14T04:32:34+00:00

With the proper NULL checks we don't need the stackframe,
use a passed in context instead.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Use talloc_asprintf_addbuf() in str_list_join_shell()

2022-12-14T04:32:34+00:00

This adds proper NULL checks via talloc_asprintf_addbuf()

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Use talloc_asprintf_addbuf() in str_list_join()

2022-12-14T04:32:34+00:00

This adds intermediate NULL checks via talloc_asprintf_addbuf()

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Use talloc_asprintf_addbuf() in debug.c

2022-12-14T04:32:34+00:00

Slightly simplify debug_list_class_names_and_levels()

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Move talloc_asprintf_addbuf() to talloc

2022-12-14T04:32:34+00:00

I wanted to use this in debug.c, but this would have meant to pollute
debug's deps with a lot of stuff. Also, looking through uses of
talloc_asprint_append(), very many of those don't do NULL checks
properly and could benefit from the _addbuf() flavor. We can add a
vasprintf variant later if the need shows up.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Fix whitespace

2022-12-14T04:32:34+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib/util: use process_set_title() in tfork()

2022-12-14T01:38:29+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison