samba.git/lib/util, branch talloc-2.4.2

time.c: fix ctime which was feeded with the mtime seconds

2024-01-16T14:37:31+00:00

This bug was introduced with 53a1d034f3e47ed3c in 2020.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15550

Signed-off-by: Bjoern Jacke 
Reviewed-by: Volker Lendecke

lib/util: let is_zero_addr() return true for AF_UNSPEC

2024-01-09T10:21:34+00:00

It means the completely zero'ed structure is detected
as zero address, as AF_UNSPEC is 0.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider

lib: Confine the copy_no_nl memcpy to debug_gpfs_log()

2024-01-04T17:06:19+00:00

gpfswrap_add_trace() seems not to have a format string that could
understand the %.*s notation.

While there this removes >4k of r/w memory from every smbd.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Jan  4 17:06:19 UTC 2024 on atb-devel-224

lib: Avoid memcpy in debug_lttng_log()

2024-01-04T16:03:36+00:00

tracef() understands the %.*s format.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

lib: Avoid memcpy in debug_systemd_log()

2024-01-04T16:03:36+00:00

sd_journal_send() understands the %.*s format.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

librpc: Change type of ‘u16string’ from ‘const uint16_t ’ to ‘const unsigned char ’

2023-12-21T23:48:46+00:00

A u16string is supposed to contain UTF‐16 code units, but
ndr_pull_u16string() and ndr_push_u16string() fail to correctly ensure
this on big‐endian systems. Code that relies on the u16string array
containing correct values will then fail.

Fix ndr_pull_u16string() and ndr_push_u16string() to work on big‐endian
systems, ensuring that other code can use these strings without having
to worry about first encoding them to little‐endian.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:util: Use portable integer constants

2023-12-21T20:21:34+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:util: Remove redundant casts in PUSH_*() macros

2023-12-21T20:21:34+00:00

The PUSH_*() macros already cast their arguments to the expected type,
so we don’t need to cast the arguments *again* prior to invoking the
macros.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:util: Don’t unnecessarily parenthesize macro arguments

2023-12-21T20:21:34+00:00

If we’re just passing a parameter to another macro which we know
correctly parenthesizes its arguments, then we don’t need to
parenthesize the parameter ourselves.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:util: Cast macro parameter ‘val’ to expected type

2023-12-21T20:21:34+00:00

These macros are now consistent with PUSH_BE_U8() and with the
PUSH_LE_*() macros.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

samba.git/lib/util, branch talloc-2.4.2

time.c: fix ctime which was feeded with the mtime seconds

lib/util: let is_zero_addr() return true for AF_UNSPEC

lib: Confine the copy_no_nl memcpy to debug_gpfs_log()

lib: Avoid memcpy in debug_lttng_log()

lib: Avoid memcpy in debug_systemd_log()

librpc: Change type of ‘u16string’ from ‘const uint16_t *’ to ‘const unsigned char *’

lib:util: Use portable integer constants

lib:util: Remove redundant casts in PUSH_*() macros

lib:util: Don’t unnecessarily parenthesize macro arguments

lib:util: Cast macro parameter ‘val’ to expected type

librpc: Change type of ‘u16string’ from ‘const uint16_t ’ to ‘const unsigned char ’