samba.git/libcli/cldap, branch talloc-2.3.2

CVE-2020-10704: libcli ldap_message: Add search size limits to ldap_decode

2020-05-04T02:59:32+00:00

Add search request size limits to ldap_decode calls.

The ldap server uses the smb.conf variable
"ldap max search request size" which defaults to 250Kb.
For cldap the limit is hard coded as 4096.

Credit to OSS-Fuzz

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

CVE-2020-10704: lib util asn1: Add ASN.1 max tree depth

2020-05-04T02:59:31+00:00

Add maximum parse tree depth to the call to asn1_init, which will be
used to limit the depth of the ASN.1 parse tree.

Credit to OSS-Fuzz

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

libcli/cldap: clang: Fix 'Dereference of null pointer'

2019-07-16T22:52:24+00:00

Fixes:

libcli/cldap/cldap.c:144:8: warning: Dereference of null pointer <--[clang]
                ev = c->searches.list->caller.ev;
                     ^
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

tevent: Fix callers of tevent_req_set_endtime

2018-04-24T17:41:15+00:00

tevent_req_set_endtime internally already calls tevent_req_nomem and thus sets
the error status correctly.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

cldap: Avoid a ZERO_STRUCTP

2018-04-03T22:44:22+00:00

This is done implicitly by tevent_req_create

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 
Reviewed-by: Stefan Metzmacher

s3: cldap: cldap_multi_netlogon_send() fails with one bad IPv6 address.

2016-10-18T00:16:20+00:00

Analysis by: Rebecca Gellman 

Ignore cldap_socket_init() failure when sending
multiple cldap netlogon requests. Allow cldap_netlogon_send()
to catch the bad address and correctly return through a
tevent subreq.

Make sure cldap_search_send() copes with cldap parameter == NULL.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12381

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Tue Oct 18 02:16:20 CEST 2016 on sn-devel-144

dlist: remove unneeded type argument from DLIST_ADD_END()

2016-02-06T20:48:17+00:00

Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison

libcli: Remove a reference to asn1->ofs

2016-01-05T23:54:18+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Make sure status is initialized.

2014-10-31T02:47:40+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

libcli: Remove unreachable code in cldap.

2014-09-27T23:32:09+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam