samba.git/libcli/dns, branch talloc-2.4.4

Minimal EDNS0 support for built-in DNS client

2025-01-02T17:01:30+00:00

Currently, samba built-in DNS client is UDP-only (it does
support TCP mode, but not all components use it).  In
particular, when winbind queries list of AD DCs (SRV
record) which can be quite large, it uses UDP-only query.
And at the same time, samba DNS client does not support
EDNS0 at all, so the reply is limited to standard DNS
packet size which is 512 bytes.

Add minimal EDNS0 OPT record to ADDITIONAL section when
sending a DNS request out, indicating we can accept
DNS packets up to 4Kb in size.

Since DNSSEC is in wide use today and DNSSEC requires
EDNS0, it is okay to assume ENDS0 is widely supported
these days, so there should be no regressions when
enabling EDNS0.

Signed-off-by: Michael Tokarev 
Reviewed-by: Andreas Schneider 
Reviewed-by: Pavel Filipenský

libcli: Add missing newlines to logging messages

2023-08-08T04:39:36+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

libcli/dns: Fix TCP fallback

2022-01-20T18:01:41+00:00

A customer has come across a DNS server that really just cuts a SRV
reply if it's too long. This makes the packet invalid according to
ndr_pull and according to wireshark. DNS_FLAG_TRUNCATION is however
set. As this seems to be legal according to the DNS RFCs, we need to
hand-parse the first two uint16's and look whether DNS_FLAG_TRUNCATION
is set.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Jan 20 18:01:41 UTC 2022 on sn-devel-184

libcli/dns: smb.conf dns forwarder port support

2021-09-28T09:44:35+00:00

Call new tsocket_address_inet_from_hostport_strings() instead of
tsocket_address_inet_from_strings() to implement setting a port to query
for a DNS forwarder.

Signed-off-by: Matthew Grant 
Reviewed-by: Uri Simchoni 
Reviewed-by: Andrew Bartlett

libcli: Add required #includes to libcli/dns/dns.h

2020-12-11T18:29:32+00:00

Also, make it safe against being included twice

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

build: Do not build selftest binaries for builds without --enable-selftest

2019-11-22T11:48:59+00:00

Add new for_selftest option to SAMBA_BINARY() and SAMBA3_BINARY()

This allows us to be much more consistent (at least in the core Samba)
and documents clearly why the binary should not be installed.

Not modified are
 - test_lp_load
 - notifyd-tests
 - gendrandperf
 - test* from examples/libsmbclient
 - dbwrap_torture
 - split_tokens
 - locktest2
 - msgtest
 - msg_sink
 - msg_source
 - versiontest
 - rpc_open_tcp
 - test_headers

As these are not tested in selftest so any change would also be
untested.  Of course they probably should be added in a different
MR.

Also not modified (because they are not tests, nor part of the
build system) are:
 - smb2mount
 - notifydd
 - log2pacp
 - debug2html
 - smbfilter
 - destroy_netlogon_creds_cli
 - spotlight2*
 - tevent_glib_tracker

These do however appear to be untested.

For now, the source4 forked client tools are left unchanged:
 - smbclient4
 - nmblookup4

Finally, the heimdal binaries are left as install=False as
they are either part of the build system or end-user tools
that we just don't want to install.  These are however tested.

The motivation is commit like c34ec003b7d45aa4196ff93a0ac29694b25e5309
and da87fa998ab71328f30bcdf5b41aee8675aee48a, which are both totally
correct but are not needed if the selftest is not run on MacOS.

There are likely other platforms or build environments where building
our test binaries is more pain than valuable, see for example also
https://lists.samba.org/archive/samba/2019-November/227137.html

Signed-off-by: Andrew Bartlett 
Reviewed-by: Isaac Boukris 

Autobuild-User(master): Isaac Boukris 
Autobuild-Date(master): Fri Nov 22 11:48:59 UTC 2019 on sn-devel-184

lib: Only compile resolvconftest if fmemopen exists

2019-05-25T00:05:25+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13961
Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Böhme 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat May 25 00:05:25 UTC 2019 on sn-devel-184

lib: Initialize variables in parse_resolvconf_fp

2019-04-09T18:29:14+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

lib: Initialize getline() arguments

2019-04-09T18:29:13+00:00

Keep "len" valid across the loop iterations for getline to consume

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13892

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

Fix tests when building with selftest but without developer

2019-01-25T20:57:57+00:00

Signed-off-by: Isaac Boukris 
Reviewed-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Fri Jan 25 21:57:57 CET 2019 on sn-devel-144