samba.git/libcli/ldap, branch talloc-2.3.2

libcli: Use GUID_to_ndr_buf() in ldap_encode_ndr_GUID()

2020-10-02T21:30:33+00:00

Avoid a talloc/free

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli/ldap: Fix CID 1462695 Resource leak

2020-08-06T19:00:36+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli/ldap: Fix CID 1462696 Resource leak

2020-08-06T19:00:36+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli/ldap: Fix CID 1465278 Resource leak

2020-08-06T19:00:36+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli/ldap: Fix decoding struct ldap_ExtendedResponse

2020-07-09T20:16:40+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

libcli/ldap: Test decoding an exop response

2020-07-09T20:16:40+00:00

ldap-starttls-response.dat is a reply to a starttls extended
operation. Right now ldap_decode() does not handle this correctly.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

libcli ldap tests: remove use of zero length array

2020-06-23T02:15:35+00:00

libcli/ldap/tests/ldap_message_test.c defines a zero length array
(uint8_t buf[0]), which is a GCC extension and breaks the build with
some strict compilers like xlc.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14387

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Jun 23 02:15:35 UTC 2020 on sn-devel-184

CVE-2020-10704 libcli ldap: Check search request lengths.

2020-05-04T04:40:10+00:00

Check the search request lengths against the limits passed to
ldap_decode.

Credit to OSS-Fuzz

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Gary Lockyer 
Autobuild-Date(master): Mon May  4 04:40:10 UTC 2020 on sn-devel-184

CVE-2020-10704: libcli ldap_message: Add search size limits to ldap_decode

2020-05-04T02:59:32+00:00

Add search request size limits to ldap_decode calls.

The ldap server uses the smb.conf variable
"ldap max search request size" which defaults to 250Kb.
For cldap the limit is hard coded as 4096.

Credit to OSS-Fuzz

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

CVE-2020-10704: libcli ldap: test recursion depth in ldap_decode_filter_tree

2020-05-04T02:59:32+00:00

Add tests to check that ASN.1 ldap requests with deeply nested elements
are rejected.  Previously there was no check on the on the depth of
nesting and excessive nesting could cause a stack overflow.

Credit to OSS-Fuzz

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett