samba.git/libcli/nbt, branch talloc-2.4.4

libcli:nbt: Initialize struct nbt_name_register

2024-07-16T11:41:33+00:00

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/libcli/nbt/pynbt.c:277: var_decl: Declaring variable ""io"" without initializer.
samba-4.20.0rc2/libcli/nbt/pynbt.c:305: uninit_use_in_call: Using uninitialized value ""io.in.nb_flags"" when calling ""nbt_name_register"".
  303|   		return NULL;
  304|
  305|-> 	status = nbt_name_register(node->socket, NULL, &io);
  306|
  307|   	if (NT_STATUS_IS_ERR(status)) {"

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner

lib: Give lib/util/util_file.c its own header file

2024-04-16T23:51:45+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

libcli/nbt: add nbt_name_send_raw()

2024-04-05T12:24:41+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

Use python.h from libreplace

2023-11-20T15:37:33+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15513

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

librpc:ndr: Introduce ‘ndr_flags_type’ type

2023-11-01T20:10:45+00:00

Instead of ‘int’ or ‘uint32_t’, neither of which convey much meaning,
consistently use a newly added type to hold NDR_ flags.

Update the NDR 4.0.0 ABI.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

ndr: Display values for failed range checks

2023-09-27T02:43:28+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9914

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

librpc/nbt: Avoid reading invalid member of union

2023-07-07T01:14:06+00:00

WACK packets use the ‘data’ member of the ‘nbt_rdata’ union, but they
claim to be a different type — NBT_QTYPE_NETBIOS — than would normally
be used with that union member. This means that if rr_type is equal to
NBT_QTYPE_NETBIOS, ndr_push_nbt_res_rec() has to guess which type the
structure really is by examining the data member. However, if the
structure is actually of a different type, that union member will not be
valid and accessing it will invoke undefined behaviour.

To fix this, eliminate all the guesswork and introduce a new type,
NBT_QTYPE_WACK, which can never appear on the wire, and which indicates
that although the ‘data’ union member should be used, the wire type is
actually NBT_QTYPE_NETBIOS.

This means that as far as NDR is concerned, the ‘netbios’ member of the
‘nbt_rdata’ union will consistently be used for all NBT_QTYPE_NETBIOS
structures; we shall no longer access the wrong member of the union.

Credit to OSS-Fuzz.

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=38480

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15019

Signed-off-by: Joseph Sutton 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Fri Jul  7 01:14:06 UTC 2023 on atb-devel-224

lib: Remove idtree from samba_util.h

2023-01-10T00:28:37+00:00

No need to recompile the world when only a few files need this.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Add "starting_id" to idr_get_new_random()

2023-01-10T00:28:37+00:00

To be used in smbXsrv_open.c, for this we need a lower bound.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

nmblookup: don't ignore unknown options

2021-09-10T15:10:30+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14828

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher