samba.git/libcli/netlogon/netlogon.c, branch talloc-2.3.1

libcls/netlogon: clang: Fix 'initialization value is never read'

2019-07-16T22:52:24+00:00

Fixes:

libcli/netlogon/netlogon.c:183:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libcli/netlogon/netlogon.c:224:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

Note: although use of default seems unecessary but gcc
(with --picky-developer) detects the possibiliy still that status
may be undefined (presumably by a non enum value leaking
into the switch)

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/netlogon: We need to handle a bug in FreeIPA (at least <= 4.1.2).

2015-01-05T16:01:08+00:00

They include the ip address information without setting
NETLOGON_NT_VERSION_5EX_WITH_IP, while using
ndr_push_NETLOGON_SAM_LOGON_RESPONSE_EX instead of
ndr_push_NETLOGON_SAM_LOGON_RESPONSE_EX_with_flags.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Guenther Deschner

netlogon: move netlogon helpers to ../libcli/netlogon.

2011-01-07T14:02:24+00:00

Guenther