samba.git/libcli/netlogon, branch talloc-2.4.0

libcli: Covscan: unchecked return value for file_save()

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall

libcli: Fix trailing whitespace in netlogon.c

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall

CVE-2020-25717: Add FreeIPA domain controller role

2021-11-09T19:45:33+00:00

As we want to reduce use of 'classic domain controller' role but FreeIPA
relies on it internally, add a separate role to mark FreeIPA domain
controller role.

It means that role won't result in ROLE_STANDALONE.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14801
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14556

Pair-Programmed-With: Stefan Metzmacher 

Signed-off-by: Alexander Bokovoy 
Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

libcls/netlogon: clang: Fix 'initialization value is never read'

2019-07-16T22:52:24+00:00

Fixes:

libcli/netlogon/netlogon.c:183:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libcli/netlogon/netlogon.c:224:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

Note: although use of default seems unecessary but gcc
(with --picky-developer) detects the possibiliy still that status
may be undefined (presumably by a non enum value leaking
into the switch)

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/netlogon: We need to handle a bug in FreeIPA (at least <= 4.1.2).

2015-01-05T16:01:08+00:00

They include the ip address information without setting
NETLOGON_NT_VERSION_5EX_WITH_IP, while using
ndr_push_NETLOGON_SAM_LOGON_RESPONSE_EX instead of
ndr_push_NETLOGON_SAM_LOGON_RESPONSE_EX_with_flags.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Guenther Deschner

waf: convert NDR_NBT into shared library.

2011-11-03T17:35:09+00:00

Guenther

nbt: move netlogon_samlogon_response into librpc/ndr/ndr_nbt.h.

2011-11-03T17:35:08+00:00

Guenther

nbt: merge in LIBCLI_NDR_NETLOGON helper into NDR_NBT.

2011-11-03T17:35:08+00:00

Guenther

librpc: remove nbt dependency to svcctl.

2011-11-03T17:35:08+00:00

Guenther

librpc: remove nbt dependency to samr.

2011-11-03T17:35:08+00:00

Guenther