samba.git/libcli/security, branch talloc-2.2.0

build: Remove bld.gen_python_environments()

2019-03-21T04:06:14+00:00

This was part of --extra-python support.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam

lib: Remove "struct sid_parse_ret" again

2019-03-12T00:42:19+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett

lib: Make sid_parse return the parsed length

2019-03-12T00:42:19+00:00

Use a temporary struct as a return value to make the compiler catch all
callers. If we just changed bool->ssize_t, this would just generate a
warning. struct sid_parse_ret will go away in the next commit

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett

libcli/security: fix handling of deny type ACEs in access_check_max_allowed()

2019-03-04T18:11:16+00:00

Deny ACEs must always be evaluated against explicitly granted rights
from previous ACEs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

libcli/security: correct access check and maximum access calculation for Owner Rights ACEs

2019-03-04T18:11:16+00:00

We basically must process the Owner Rights ACEs as any other ACE wrt to the
order of adding granted permissions and checking denied permissions. According
to MS-DTYP 2.5.3.2 Owner Rights ACEs must be evaluated in the main loop over
the ACEs in an ACL and the corresponding access_mask must be directly applied
to bits_remaining. We currently defer this to after the loop over the ACEs in
ACL, this is wrong.

We just have to do some initial magic to determine if an ACL contains and
Owner Rights ACEs, and in case it doesn't we grant SEC_STD_WRITE_DAC |
SEC_STD_READ_CONTROL at the *beginning*. MS-DTYP:

-- the owner of an object is always granted READ_CONTROL and WRITE_DAC.
CALL SidInToken(Token, SecurityDescriptor.Owner, PrincipalSelfSubst)
IF SidInToken returns True THEN
   IF DACL does not contain ACEs from object owner THEN
       Remove READ_CONTROL and WRITE_DAC from RemainingAccess
       Set GrantedAccess to GrantedAccess or READ_CONTROL or WRITE_OWNER
   END IF
END IF

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

libcli: Use wrapper for string to integer conversion

2019-03-01T00:32:11+00:00

In order to detect an value overflow error during
the string to integer conversion with strtoul/strtoull,
the errno variable must be set to zero before the execution and
checked after the conversion is performed. This is achieved by
using the wrapper function strtoul_err and strtoull_err.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Böhme 
Reviewed-by: Jeremy Allison

libcli/security: add "Owner Rights" calculation to access_check_max_allowed()

2019-02-28T19:18:16+00:00

This was missing in 44590c1b70c0a24f853c02d5fcdb3c609401e2ca.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Thu Feb 28 19:18:16 UTC 2019 on sn-devel-144

sddl: Use C99 initializer for sid_codes

2019-01-28T09:29:23+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Douglas Bagnall

libcli:security: Return early if there are no aces to duplicate

2018-12-12T21:18:52+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed Dec 12 22:18:52 CET 2018 on sn-devel-144

libcli:security: Do not duplicate invalid aces

2018-12-12T17:34:11+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke