samba.git/libcli/security, branch talloc-2.3.0

libcli: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30T11:32:18+00:00

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

libcli/security: Remove unused dup_sec_desc_buf()

2019-05-22T05:59:14+00:00

This has been unused since before
762e7e1dff89cc14b0130fc9a22038b0845630a2 in 2003.

Found by callcatcher

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

squash 'cast between incompatible function types' warning

2019-05-16T17:55:17+00:00

To avoid warning above produced by using
-Wcast-function-type we;

  + ensure PyCFunctions of type METH_NOARGS defined dummy arg
  + ensure PyCFunctions of type METH_KEYWORDS use PY_DISCARD_FUNC_SIG
    macro

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

libcli: Update error check for new string conversion wrapper

2019-04-11T22:29:27+00:00

The new string conversion wrappers detect and flag errors
which occured during the string to integer conversion.
Those modifications required an update of the callees
error checks.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

build: Remove bld.gen_python_environments()

2019-03-21T04:06:14+00:00

This was part of --extra-python support.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam

lib: Remove "struct sid_parse_ret" again

2019-03-12T00:42:19+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett

lib: Make sid_parse return the parsed length

2019-03-12T00:42:19+00:00

Use a temporary struct as a return value to make the compiler catch all
callers. If we just changed bool->ssize_t, this would just generate a
warning. struct sid_parse_ret will go away in the next commit

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett

libcli/security: fix handling of deny type ACEs in access_check_max_allowed()

2019-03-04T18:11:16+00:00

Deny ACEs must always be evaluated against explicitly granted rights
from previous ACEs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

libcli/security: correct access check and maximum access calculation for Owner Rights ACEs

2019-03-04T18:11:16+00:00

We basically must process the Owner Rights ACEs as any other ACE wrt to the
order of adding granted permissions and checking denied permissions. According
to MS-DTYP 2.5.3.2 Owner Rights ACEs must be evaluated in the main loop over
the ACEs in an ACL and the corresponding access_mask must be directly applied
to bits_remaining. We currently defer this to after the loop over the ACEs in
ACL, this is wrong.

We just have to do some initial magic to determine if an ACL contains and
Owner Rights ACEs, and in case it doesn't we grant SEC_STD_WRITE_DAC |
SEC_STD_READ_CONTROL at the *beginning*. MS-DTYP:

-- the owner of an object is always granted READ_CONTROL and WRITE_DAC.
CALL SidInToken(Token, SecurityDescriptor.Owner, PrincipalSelfSubst)
IF SidInToken returns True THEN
   IF DACL does not contain ACEs from object owner THEN
       Remove READ_CONTROL and WRITE_DAC from RemainingAccess
       Set GrantedAccess to GrantedAccess or READ_CONTROL or WRITE_OWNER
   END IF
END IF

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

libcli: Use wrapper for string to integer conversion

2019-03-01T00:32:11+00:00

In order to detect an value overflow error during
the string to integer conversion with strtoul/strtoull,
the errno variable must be set to zero before the execution and
checked after the conversion is performed. This is achieved by
using the wrapper function strtoul_err and strtoull_err.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Böhme 
Reviewed-by: Jeremy Allison