samba.git/libcli/smb, branch talloc-2.3.0

libcli/smb: clang: Fix ' 2nd function call argument is an uninitialized value'

2019-07-16T22:52:25+00:00

Fixes:

/home/samba/samba/libcli/smb/smbXcli_base.c:5120:8: warning: 2nd function call argument is an uninitialized value <--[clang]
                rc = gnutls_hash(hash_hnd,

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/smb: clang: Fix 'Dereference of null pointer'

2019-07-16T22:52:25+00:00

Fixes:

smbXcli_base.c:4885:20: warning: Dereference of null pointer <--[clang]
        body = (uint8_t *)iov[1].iov_base;
                          ^~~~~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/smb: clang: Fix 'Array access results in a null pointer deref'

2019-07-16T22:52:24+00:00

Fixes:

smbXcli_base.c:4393:10: warning: Array access (from variable 'inhdr') results in a null pointer dereference <--[clang]
        flags = CVAL(inhdr, HDR_FLG);

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/smb: clang: Fix 'array access results in a null pointer deref'

2019-07-16T22:52:24+00:00

Fixes:

smbXcli_base.c:1239:9: warning: Array access (via field 'pending') results in a null pointer dereference <--[clang]
                req = conn->pending[0];
                      ^

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcl/smb: clang: Fix 'Value stored to 'next_offset' is never read'

2019-07-11T04:08:13+00:00

Fixes:

 libcli/smb/smb2_create_blob.c:146:3: warning: Value stored to 'next_offset' is never read <--[clang]
                next_offset += next_pad;
                ^              ~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/smb: clang: Fix 'value stored to 'p' is never read'

2019-07-11T04:08:13+00:00

Fixes:

libcli/smb/smb1cli_session.c:226:2: warning: Value stored to 'p' is never read <--[clang]
        p += ret;
        ^    ~~~
libcli/smb/smb1cli_session.c:517:2: warning: Value stored to 'p' is never read <--[clang]
        p += ret;
        ^    ~~~
Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

lib/crypto: move gnutls error wrapper to own subsystem

2019-06-27T12:54:22+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

libcli:smb: Use gnutls_error_to_ntstatus() in smb_signing

2019-06-24T06:11:17+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

libcli:smb: Use gnutls_error_to_ntstatus() in smbXcli_base.c

2019-06-24T06:11:17+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

libcli:smb: Use gnutls_error_to_ntstatus() in smb2_signing_check_pdu()

2019-06-24T06:11:16+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett