samba.git/libcli/smb, branch talloc-2.3.3

libcli/smb: let smb2_negotiate_context_parse() only parse the expected number of contexts

2021-07-12T21:25:21+00:00

Any garbage at the end needs to be ignored.

This fixes the Negotiate_SMB311_ContextID_NetName test from:
https://github.com/microsoft/WindowsProtocolTestSuites/blob/main/TestSuites/FileServer/src/SMB2/TestSuite/Negotiate/Negotiation.cs#L730

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Mon Jul 12 21:25:21 UTC 2021 on sn-devel-184

libcli smb smb2: Use correct enumeration type

2021-03-29T23:19:24+00:00

Clang gives the following error:
../../libcli/smb/smb2_signing.c:547:48: error:
   implicit conversion from enumeration type 'gnutls_mac_algorithm_t'
   to different enumeration type 'gnutls_digest_algorithm_t'
   [-Werror,-Wenum-conversion]
   const size_t digest_len = gnutls_hash_get_len(GNUTLS_MAC_SHA256);
~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~

Should be using GNUTLS_DIG_SHA256, which is set to GNUTLS_MAC_SHA256.

Signed-off-by: Gary Lockyer 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Gary Lockyer 
Autobuild-Date(master): Mon Mar 29 23:19:24 UTC 2021 on sn-devel-184

libcli/smb: make use of smb3_capabilities.encryption

2021-03-17T00:49:32+00:00

This avoids a hardcoded list of possible ciphers.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

libcli/smb: introduce struct smb3_encryption_capabilities

2021-03-17T00:49:32+00:00

This will allow us to control the offered ciphers from the callers
later.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

libcli/smb: pass smb3_capabilities to smbXcli_conn_create()

2021-03-17T00:49:32+00:00

Passing NULL means use none.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

libcli/smb: introduce struct struct smb311_capabilities

2021-03-17T00:49:32+00:00

This will be filled later with supported ciphers and other
things that can be negotiated in SMB >= 3.1.1.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

libcli/smb: don't copy the key to a stack variable in smb2_signing_{encrypt,decrypt}_pdu()

2021-03-17T00:49:32+00:00

The key size should always match now.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

libcli/smb: no longer pass protocol to smb2_signing_{encrypt,decrypt}_pdu()

2021-03-17T00:49:32+00:00

The cipher algorithm is already passed via
smb2_signing_key->chipher_algo_id.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

libcli/smb: no longer pass protocol to smb2_signing_{sign,check}_pdu()

2021-03-17T00:49:32+00:00

The signing algorithm is already passed via
smb2_signing_key->sign_algo_id.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

libcli/smb: make smb2_signing_key_destructor static

2021-03-17T00:49:32+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison