<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/libcli/smb, branch talloc-2.3.4</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>libcli/smb: allow SMB2 Negotiate responses with security_offset = 0 and security_length = 0</title>
<updated>2022-05-02T20:13:10+00:00</updated>
<author>
<name>Stefan Metzmacher</name>
<email>metze@samba.org</email>
</author>
<published>2022-04-26T08:38:15+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=54c6cf8666b073818301d3a71a37453b44e57b5c'/>
<id>54c6cf8666b073818301d3a71a37453b44e57b5c</id>
<content type='text'>
This fixes connections against the Azure SMB3 server.

It's not possible to demonstrate the bug with a test and a knownfail
entry, because it fails to even startup the test environments,
but the following change to our server demonstrates the problem
and shows the fix works:

    diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c
    index da567951c0bf..25fdaea2df7b 100644
    --- a/source3/smbd/smb2_negprot.c
    +++ b/source3/smbd/smb2_negprot.c
    @@ -711,6 +711,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req)
                    }
            }

    +       security_buffer = data_blob_null;
    +
            if (out_negotiate_context_blob.length != 0) {
                    static const uint8_t zeros[8];
                    size_t pad = 0;
    @@ -759,6 +761,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req)
                    return smbd_smb2_request_error(req, NT_STATUS_NO_MEMORY);
            }

    +       security_offset = 0;
    +
            SSVAL(outbody.data, 0x00, 0x40 + 1);    /* struct size */
            SSVAL(outbody.data, 0x02,
                  security_mode);                   /* security mode */

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15050

Signed-off-by: Stefan Metzmacher &lt;metze@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Mon May  2 20:13:10 UTC 2022 on sn-devel-184
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes connections against the Azure SMB3 server.

It's not possible to demonstrate the bug with a test and a knownfail
entry, because it fails to even startup the test environments,
but the following change to our server demonstrates the problem
and shows the fix works:

    diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c
    index da567951c0bf..25fdaea2df7b 100644
    --- a/source3/smbd/smb2_negprot.c
    +++ b/source3/smbd/smb2_negprot.c
    @@ -711,6 +711,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req)
                    }
            }

    +       security_buffer = data_blob_null;
    +
            if (out_negotiate_context_blob.length != 0) {
                    static const uint8_t zeros[8];
                    size_t pad = 0;
    @@ -759,6 +761,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req)
                    return smbd_smb2_request_error(req, NT_STATUS_NO_MEMORY);
            }

    +       security_offset = 0;
    +
            SSVAL(outbody.data, 0x00, 0x40 + 1);    /* struct size */
            SSVAL(outbody.data, 0x02,
                  security_mode);                   /* security mode */

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15050

Signed-off-by: Stefan Metzmacher &lt;metze@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Mon May  2 20:13:10 UTC 2022 on sn-devel-184
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Rename smb_key_derivation() -&gt; smb1_key_derivation()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:41:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=3e021c3762fce4f5c238da5ab36797c3d6fba1a5'/>
<id>3e021c3762fce4f5c238da5ab36797c3d6fba1a5</id>
<content type='text'>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Rename smb_signing_is_negotiated() -&gt; smb1_signing_is_negotiated()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:39:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=0b391fc19f7098ce2f7b8faf22adab1fbb34bee7'/>
<id>0b391fc19f7098ce2f7b8faf22adab1fbb34bee7</id>
<content type='text'>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Rename smb_signing_set_negotiated() -&gt; smb1_signing_set_negotiated()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:38:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=7a385775eeccd5a36a2767052133c7e4bcfbf904'/>
<id>7a385775eeccd5a36a2767052133c7e4bcfbf904</id>
<content type='text'>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Rename smb_signing_is_mandatory() -&gt; smb1_signing_is_mandatory()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:36:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=79633b42d6199da3b9764c28772308de08c3c94e'/>
<id>79633b42d6199da3b9764c28772308de08c3c94e</id>
<content type='text'>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Rename smb_signing_is_desired() -&gt; smb1_signing_is_desired()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:34:42+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=e42fc9bc24deb288fad14c99bcf5a63435c5cd83'/>
<id>e42fc9bc24deb288fad14c99bcf5a63435c5cd83</id>
<content type='text'>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Remove unused smb_signing_is_allowed()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:33:23+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=2fd29169714bd5e768789e24de34c7a7efd80a07'/>
<id>2fd29169714bd5e768789e24de34c7a7efd80a07</id>
<content type='text'>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Rename smb_signing_is_active() -&gt; smb1_signing_is_active()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:31:34+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=0c8bc1bf5689753cfbc1bc35d6cfba506446ac68'/>
<id>0c8bc1bf5689753cfbc1bc35d6cfba506446ac68</id>
<content type='text'>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Rename smb_signing_activate() -&gt; smb1_signing_activate()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:29:57+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=8dd252ad91bf9ec4b6d993a49eb873f79ca33d28'/>
<id>8dd252ad91bf9ec4b6d993a49eb873f79ca33d28</id>
<content type='text'>
Fix the debugs that also used this name.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix the debugs that also used this name.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: libcli: Rename smb_signing_check_pdu() -&gt; smb1_signing_check_pdu()</title>
<updated>2022-03-08T22:12:37+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2022-03-08T03:26:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=84a498feeca62f0263e2c536cfd24bf37965ff87'/>
<id>84a498feeca62f0263e2c536cfd24bf37965ff87</id>
<content type='text'>
Fix the debugs that also used this name.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix the debugs that also used this name.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Signed-off-by: David Mulder &lt;dmulder@samba.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
