samba.git/libcli/smbreadline, branch talloc-2.4.4

lib:replace: Don't use deprecated readline CPPFunction cast

2025-01-21T19:38:36+00:00

HAVE_RL_COMPLETION_FUNC_T was unused and not checking for the right
function.

libcli/smbreadline/smbreadline.c: In function ‘smb_readline’:
libcli/smbreadline/smbreadline.c:139:17: warning: ‘CPPFunction’ is deprecated [-Wdeprecated-declarations]
  139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libcli/smbreadline/smbreadline.c:139:50: error: assignment to ‘char ** (*)(const char *, int,  int)’ from incompatible pointer type ‘char ** (*)(void)’ [-Wincompatible-pointer-types]
  139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
      |                                                  ^

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15788

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Jan 21 19:38:37 UTC 2025 on atb-devel-224

libcli:smbreadline: Fix code spelling

2023-06-23T13:44:31+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

libcli:smbreadline: Use #ifdef instead of #if for config.h definitions

2018-11-28T22:19:22+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer

lib/smbreadline: detect picky compile issue with readline.h

2017-11-24T00:13:15+00:00

readline.h has build issues with clang if -Wstrict-prototypes
is enabled. Detect this and also detect whether the known
workaround works.

Fix suggested by Timur I. Bakeyev 

cf. https://lists.gnu.org/archive/html/bug-readline/2014-04/msg00018.html
cf. https://lists.samba.org/archive/samba-technical/2017-November/123923.html

Signed-off-by: Uri Simchoni 
Reviewed-by: Andrew Bartlett

lib: smbreadline xfile->stdio

2016-12-11T10:17:24+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Remove global xfile.h includes

2016-11-20T05:23:19+00:00

This makes it more obvious where this legacy code is used

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sun Nov 20 06:23:19 CET 2016 on sn-devel-144

Change the libreadline word-break character set to only space, TAB and NL so that we can attempt to do tab completion across backslashes.

2015-10-07T02:16:24+00:00

This turned out to be all that was needed to enable cd to handle multiple
directory levels.

Signed-off-by: Richard Sharpe 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Oct  7 04:16:24 CEST 2015 on sn-devel-104

smbreadline: switch to new-style readline typedef

2014-03-12T23:21:44+00:00

Function, CPFunction, CPPFunction and VFunction typedefs are considered
old-style (deprecated) starting from readline 4.2 (circa 2001).
Compatibility typedefs have been in place up to readline 6.2 but were
removed with the 6.3 release thus causing builds to break.
Switch to the new-style specific prototyped typedef.

Return value is unused so the callback should still be void (see
readline/input.c around line 456 in version 6.3).

Signed-off-by: Gustavo Zacarias 
Reviewed-by: Jeremy Allison 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Mar 13 00:21:47 CET 2014 on sn-devel-104

libcli/smbreadline/smbreadline.h: fix licence/copyright

2011-06-10T13:11:43+00:00

Guenther

libcli: Eliminate select from smb_readline_replacement

2011-02-28T15:40:20+00:00