samba.git/libcli, branch talloc-2.1.14

libcli: Fix coverity warning in smb2cli_notify_send()

2018-05-16T19:30:23+00:00

result_independent_of_operands: "(uint16_t)(recursive ? 1 : 0) >> 8" is
0 regardless of the values of its operands. This occurs as the operand
of assignment.

Found by Coverity.

Pair-Programmed-With: Ralph Boehme 

Signed-off-by: Andreas Schneider 
Signed-off-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett

Fix spelling s/conection/connection/

2018-05-12T00:09:26+00:00

Signed-off-by: Mathieu Parent 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Garming Sam

libcli: remove unused se_create_child_secdesc_buf()

2018-05-09T17:18:43+00:00

Commit e2c9ad93cb914186b89e2055f1bed3cceee1f768 removed the last caller
of this.

Signed-off-by: Ralph Boehme 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Wed May  9 19:18:44 CEST 2018 on sn-devel-144

libcli/nbt: Additionally accept unicode as string param in Py2

2018-04-30T13:43:19+00:00

With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places where the type is directly checked e.g. via PyStr_Check etc.
arguments that are parsed by ParseTuple* functions generally already
accept both string and unicode (if 's', 'z', 's*' format specifiers
are used)

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy

tevent: Fix callers of tevent_req_set_endtime

2018-04-24T17:41:15+00:00

tevent_req_set_endtime internally already calls tevent_req_nomem and thus sets
the error status correctly.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap: Remove calls to loadparm

2018-04-23T23:53:19+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Call dbwrap_local_open with the correct tdb flags

2018-04-23T23:53:19+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Call dbwrap_local_open with the correct hash size

2018-04-23T23:53:19+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Call dbwrap_local_open with the correct tdb_flags

2018-04-23T23:53:18+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Call dbwrap_local_open with the correct hash size

2018-04-23T23:53:18+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison