samba.git/libcli, branch talloc-2.3.0

libcli/smb: clang: Fix ' 2nd function call argument is an uninitialized value'

2019-07-16T22:52:25+00:00

Fixes:

/home/samba/samba/libcli/smb/smbXcli_base.c:5120:8: warning: 2nd function call argument is an uninitialized value <--[clang]
                rc = gnutls_hash(hash_hnd,

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/smb: clang: Fix 'Dereference of null pointer'

2019-07-16T22:52:25+00:00

Fixes:

smbXcli_base.c:4885:20: warning: Dereference of null pointer <--[clang]
        body = (uint8_t *)iov[1].iov_base;
                          ^~~~~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/smb: clang: Fix 'Array access results in a null pointer deref'

2019-07-16T22:52:24+00:00

Fixes:

smbXcli_base.c:4393:10: warning: Array access (from variable 'inhdr') results in a null pointer dereference <--[clang]
        flags = CVAL(inhdr, HDR_FLG);

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/smb: clang: Fix 'array access results in a null pointer deref'

2019-07-16T22:52:24+00:00

Fixes:

smbXcli_base.c:1239:9: warning: Array access (via field 'pending') results in a null pointer dereference <--[clang]
                req = conn->pending[0];
                      ^

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/cldap: clang: Fix 'Dereference of null pointer'

2019-07-16T22:52:24+00:00

Fixes:

libcli/cldap/cldap.c:144:8: warning: Dereference of null pointer <--[clang]
                ev = c->searches.list->caller.ev;
                     ^
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcls/netlogon: clang: Fix 'initialization value is never read'

2019-07-16T22:52:24+00:00

Fixes:

libcli/netlogon/netlogon.c:183:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libcli/netlogon/netlogon.c:224:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

Note: although use of default seems unecessary but gcc
(with --picky-developer) detects the possibiliy still that status
may be undefined (presumably by a non enum value leaking
into the switch)

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcl/smb: clang: Fix 'Value stored to 'next_offset' is never read'

2019-07-11T04:08:13+00:00

Fixes:

 libcli/smb/smb2_create_blob.c:146:3: warning: Value stored to 'next_offset' is never read <--[clang]
                next_offset += next_pad;
                ^              ~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli/smb: clang: Fix 'value stored to 'p' is never read'

2019-07-11T04:08:13+00:00

Fixes:

libcli/smb/smb1cli_session.c:226:2: warning: Value stored to 'p' is never read <--[clang]
        p += ret;
        ^    ~~~
libcli/smb/smb1cli_session.c:517:2: warning: Value stored to 'p' is never read <--[clang]
        p += ret;
        ^    ~~~
Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

libcli: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30T11:32:18+00:00

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

libcli:auth: Return NTSTATUS for netlogon_creds_arcfour_crypt()

2019-06-27T12:54:23+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett