samba.git/libcli, branch talloc-2.3.2

http_conn.c: fix "void function cannot return value" error

2020-11-10T06:53:42+00:00

this made the studio compiler build break

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

Add smb2cli_session_get_encryption_cipher()

2020-11-06T10:02:35+00:00

When 'session->smb2->should_encrypt' is true, the client MUST encrypt
all transport messages (see also MS-SMB2 3.2.4.1.8).

Signed-off-by: Isaac Boukris 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Alexander Bokovoy

libcli: Use GUID_to_ndr_buf() in smb2cli_validate_negotiate_info_send()

2020-10-02T22:50:43+00:00

Avoid a talloc/free

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Oct  2 22:50:43 UTC 2020 on sn-devel-184

libcli: Use GUID_to_ndr_buf() in smbXcli_negprot_smb2_subreq()

2020-10-02T21:30:34+00:00

Avoid a talloc/free

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Use GUID_to_ndr_buf() in ldap_encode_ndr_GUID()

2020-10-02T21:30:33+00:00

Avoid a talloc/free

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Align some integer types

2020-10-02T21:30:33+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Don't leave a pointer uninitialized

2020-10-02T21:30:32+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libcli: Remove a pointless if-expression

2020-10-02T21:30:32+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

CVE-2020-1472(ZeroLogon): libcli/auth: reject weak client challenges in netlogon_creds_server_init()

2020-09-18T12:48:38+00:00

This implements the note from MS-NRPC 3.1.4.1 Session-Key Negotiation:

 7. If none of the first 5 bytes of the client challenge is unique, the
    server MUST fail session-key negotiation without further processing of
    the following steps.

It lets ./zerologon_tester.py from
https://github.com/SecuraBV/CVE-2020-1472.git
report: "Attack failed. Target is probably patched."

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14497

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Gary Lockyer

CVE-2020-1472(ZeroLogon): libcli/auth: add netlogon_creds_is_random_challenge() to avoid weak values

2020-09-18T12:48:38+00:00

This is the check Windows is using, so we won't generate challenges,
which are rejected by Windows DCs (and future Samba DCs).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14497

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Gary Lockyer