samba.git/libcli, branch talloc-2.3.4 Unnamed repository; edit this file 'description' to name the repository. libcli: Covscan: unchecked return value for file_save() 2022-05-14T03:49:32+00:00 Pavel Filipenský pfilipen@redhat.com 2022-05-11T09:32:47+00:00 d4e5712cafe849840f0b57c4b11774d4452e7561 Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
libcli: Fix trailing whitespace in netlogon.c 2022-05-14T03:49:32+00:00 Pavel Filipenský pfilipen@redhat.com 2022-05-11T09:31:52+00:00 6781ab1172c3baa6c567483f258ac1af1f2dadf7 Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
libcli/smb: allow SMB2 Negotiate responses with security_offset = 0 and security_length = 0 2022-05-02T20:13:10+00:00 Stefan Metzmacher metze@samba.org 2022-04-26T08:38:15+00:00 54c6cf8666b073818301d3a71a37453b44e57b5c This fixes connections against the Azure SMB3 server. It's not possible to demonstrate the bug with a test and a knownfail entry, because it fails to even startup the test environments, but the following change to our server demonstrates the problem and shows the fix works: diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c index da567951c0bf..25fdaea2df7b 100644 --- a/source3/smbd/smb2_negprot.c +++ b/source3/smbd/smb2_negprot.c @@ -711,6 +711,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req) } } + security_buffer = data_blob_null; + if (out_negotiate_context_blob.length != 0) { static const uint8_t zeros[8]; size_t pad = 0; @@ -759,6 +761,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req) return smbd_smb2_request_error(req, NT_STATUS_NO_MEMORY); } + security_offset = 0; + SSVAL(outbody.data, 0x00, 0x40 + 1); /* struct size */ SSVAL(outbody.data, 0x02, security_mode); /* security mode */ BUG: https://bugzilla.samba.org/show_bug.cgi?id=15050 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon May 2 20:13:10 UTC 2022 on sn-devel-184 
This fixes connections against the Azure SMB3 server.

It's not possible to demonstrate the bug with a test and a knownfail
entry, because it fails to even startup the test environments,
but the following change to our server demonstrates the problem
and shows the fix works:

    diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c
    index da567951c0bf..25fdaea2df7b 100644
    --- a/source3/smbd/smb2_negprot.c
    +++ b/source3/smbd/smb2_negprot.c
    @@ -711,6 +711,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req)
                    }
            }

    +       security_buffer = data_blob_null;
    +
            if (out_negotiate_context_blob.length != 0) {
                    static const uint8_t zeros[8];
                    size_t pad = 0;
    @@ -759,6 +761,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req)
                    return smbd_smb2_request_error(req, NT_STATUS_NO_MEMORY);
            }

    +       security_offset = 0;
    +
            SSVAL(outbody.data, 0x00, 0x40 + 1);    /* struct size */
            SSVAL(outbody.data, 0x02,
                  security_mode);                   /* security mode */

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15050

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon May  2 20:13:10 UTC 2022 on sn-devel-184
sddl: Remove SDDL SID strings unsupported by Windows 2022-03-17T23:11:37+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2022-03-14T05:18:39+00:00 1137ebc654e4dfd91601abd20262024063a495c8 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Stefan Metzmacher <metze@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
sddl: Add new SDDL SID strings 2022-03-17T23:11:37+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2022-03-14T05:18:09+00:00 732d17a129ab0f48d0025f5992af38d442b1fc6a Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Stefan Metzmacher <metze@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
sddl: Fix incorrect SDDL SID strings 2022-03-17T23:11:37+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2022-03-14T05:14:15+00:00 e61fa573fe1a911460cfb3b64ba05b031d124256 Change the values to match those used by Windows. Verified with PowerShell commands of the form: New-Object Security.Principal.SecurityIdentifier ER Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Stefan Metzmacher <metze@samba.org> 
Change the values to match those used by Windows.

Verified with PowerShell commands of the form:
New-Object Security.Principal.SecurityIdentifier ER

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
s3: libcli: Rename smb_key_derivation() -> smb1_key_derivation() 2022-03-08T22:12:37+00:00 Jeremy Allison jra@samba.org 2022-03-08T03:41:31+00:00 3e021c3762fce4f5c238da5ab36797c3d6fba1a5 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: David Mulder <dmulder@samba.org> 
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: David Mulder <dmulder@samba.org>
s3: libcli: Rename smb_signing_is_negotiated() -> smb1_signing_is_negotiated() 2022-03-08T22:12:37+00:00 Jeremy Allison jra@samba.org 2022-03-08T03:39:58+00:00 0b391fc19f7098ce2f7b8faf22adab1fbb34bee7 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: David Mulder <dmulder@samba.org> 
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: David Mulder <dmulder@samba.org>
s3: libcli: Rename smb_signing_set_negotiated() -> smb1_signing_set_negotiated() 2022-03-08T22:12:37+00:00 Jeremy Allison jra@samba.org 2022-03-08T03:38:35+00:00 7a385775eeccd5a36a2767052133c7e4bcfbf904 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: David Mulder <dmulder@samba.org> 
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: David Mulder <dmulder@samba.org>
s3: libcli: Rename smb_signing_is_mandatory() -> smb1_signing_is_mandatory() 2022-03-08T22:12:37+00:00 Jeremy Allison jra@samba.org 2022-03-08T03:36:25+00:00 79633b42d6199da3b9764c28772308de08c3c94e Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: David Mulder <dmulder@samba.org> 
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: David Mulder <dmulder@samba.org>